Fix initializing TrnLookup from an existing session #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some Sentry errors caused by users hitting the
/sign-in/register/email-existsafter the/sign-in/email-confirmation. That shouldn't be possible; we shouldn't be showing the 'you already have an account' interstitial when users have chosen to sign in, only when they've tried to register.I think this might be caused by the
AuthenticationStateinitialization we do from an existing cookie - clearing cookies and signing in doesn't seem to show this issue.The
IsFinished()check that we do to know we're done requiresAuthenticationState.TrnLookupto beComplete. For users who registered via magic link this will befalsesinceCompletedTrnLookupwill befalse. This change updates the initialization to setTrnLookuptoCompletewheneverTrnis not null.