Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send TrnLookupStatus claim without TRN #724

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Don't send TrnLookupStatus claim without TRN #724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dotnet-authserver/src/TeacherIdentity.AuthServer/UserClaimHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,6 @@ public async Task<IReadOnlyCollection<Claim>> GetPublicClaims(Guid userId, TrnMa

if (trnMatchPolicy is not null)
{
Debug.Assert(user.TrnLookupStatus.HasValue);
claims.Add(new Claim(CustomClaims.TrnLookupStatus, user.TrnLookupStatus!.Value.ToString()));

var haveSufficientTrnMatch = user.Trn is not null &&
(trnMatchPolicy == TrnMatchPolicy.Default ||
user.TrnVerificationLevel == TrnVerificationLevel.Medium ||
Expand All @@ -102,7 +99,10 @@ public async Task<IReadOnlyCollection<Claim>> GetPublicClaims(Guid userId, TrnMa

if (haveSufficientTrnMatch)
{
Debug.Assert(user.Trn is not null);
Debug.Assert(user.TrnLookupStatus.HasValue);
claims.Add(new Claim(CustomClaims.Trn, user.Trn!));
claims.Add(new Claim(CustomClaims.TrnLookupStatus, user.TrnLookupStatus!.Value.ToString()));

if (trnMatchPolicy == TrnMatchPolicy.Strict)
{
Expand Down
Loading