Fix selected trn from being lost when merging two records (#780)

DFE-Digital · Jan 15, 2024 · 5d661a8 · 5d661a8
1 parent 6e6dd21
commit 5d661a8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/Admin/MergeUser/Confirm.cshtml b/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/Admin/MergeUser/Confirm.cshtml
@@ -5,22 +5,22 @@
 }
 
 @section BeforeContent {
-    <govuk-back-link asp-page="SelectUser" asp-route-userId="@Model.UserId"/>
+    <govuk-back-link asp-page="SelectUser" asp-route-userId="@Model.UserId" />
 }
 
 <div class="govuk-grid-row">
     <div class="govuk-grid-column-two-thirds-from-desktop">
         <form asp-page="Confirm" method="post">
             <h1 class="govuk-heading-l">@ViewBag.Title</h1>
-
+            @Html.Hidden("ChosenTrn", Model.ChosenTrn)
             <govuk-summary-list>
                 <govuk-summary-list-row>
                     <govuk-summary-list-row-key>Email address</govuk-summary-list-row-key>
                     <govuk-summary-list-row-value>@Model.User!.EmailAddress</govuk-summary-list-row-value>
                 </govuk-summary-list-row>
                 <govuk-summary-list-row>
                     <govuk-summary-list-row-key>Name</govuk-summary-list-row-key>
-                <govuk-summary-list-row-value>@Model.User!.FirstName @Model.User!.LastName</govuk-summary-list-row-value>
+                    <govuk-summary-list-row-value>@Model.User!.FirstName @Model.User!.LastName</govuk-summary-list-row-value>
                 </govuk-summary-list-row>
                 <govuk-summary-list-row>
                     <govuk-summary-list-row-key>TRN</govuk-summary-list-row-key>

diff --git a/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/Admin/MergeUser/Confirm.cshtml.cs b/dotnet-authserver/src/TeacherIdentity.AuthServer/Pages/Admin/MergeUser/Confirm.cshtml.cs
@@ -29,9 +29,10 @@ public Confirm(TeacherIdentityServerDbContext dbContext, IClock clock)
 
     public User? UserToMerge { get; set; }
 
-    [FromQuery(Name = "trn")]
+    [BindProperty]
     public string? ChosenTrn { get; set; }
 
+
     public void OnGet()
     {
     }
@@ -121,6 +122,11 @@ private void UpdateMergedUser(User user)
 
     private bool ValidateChosenTrn()
     {
+        if (Request.Query.ContainsKey("trn"))
+        {
+            ChosenTrn = Request.Query["trn"];
+        }
+
         ChosenTrn = ChosenTrn == "None" ? null : ChosenTrn ?? User!.Trn;
         return ChosenTrn == User!.Trn || ChosenTrn == UserToMerge!.Trn;
     }