Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-govuk, rubocop-rails and rubocop-rspec #389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 7, 2024

Bumps rubocop-govuk, rubocop-rails and rubocop-rspec. These dependencies needed to be updated together.
Updates rubocop-govuk from 4.12.0 to 4.14.0

Changelog

Sourced from rubocop-govuk's changelog.

4.14.0

  • Update rubocop to 1.60.2
  • Update rubocop-rails to 2.23.1
  • Update rubocop-rspec to 2.26.1
  • Add Snyk scans to CI pipeline

4.13.0

  • Update rubocop to 1.59.0
  • Update rubocop-ast to 1.30.0
  • Update rubocop-rails to 2.23.0
  • Update rubocop-rspec to 2.25.0
Commits
  • c972d3f Merge pull request #346 from alphagov/release-4.14.0
  • 3a8b9e9 Bump to 4.14.0
  • 79be6a6 Merge pull request #345 from alphagov/dependabot/bundler/rubocop-eq-1.60.2
  • 40c96f7 Update rubocop requirement from = 1.60.1 to = 1.60.2
  • 59c8c47 Merge pull request #344 from alphagov/dependabot/bundler/rubocop-eq-1.60.1
  • d8c3dba Update rubocop requirement from = 1.60.0 to = 1.60.1
  • 9e650ed Merge pull request #343 from alphagov/dependabot/bundler/rubocop-eq-1.60.0
  • 03d239d Update rubocop requirement from = 1.59.0 to = 1.60.0
  • 9b1b6ed Merge pull request #342 from alphagov/dependabot/bundler/rubocop-rspec-eq-2.26.1
  • a8051f8 Update rubocop-rspec requirement from = 2.25.0 to = 2.26.1
  • Additional commits viewable in compare view

Updates rubocop-rails from 2.20.2 to 2.23.1

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.23.1

Bug fixes

  • #1221: Fix an exception in Rails/WhereNot when calling .where on an implicit receiver (e.g. inside model code). (@​bquorning)

RuboCop Rails 2.23.0 (The RubyConf Taiwan 2023 Edition)

New features

Bug fixes

  • #1206: Fix an error for Rails/WhereMissing where join method is called without arguments. (@​fatkodima)
  • #1189: Fix false negatives for Rails/Pluck when using safe navigation method calls. (@​koic)
  • #1204: Make Rails/ActiveSupportAliases, Rails/FindBy, Rails/FindById, Rails/Inquiry, Rails/Pick Rails/PluckId, Rails/PluckInWhere, Rails/WhereEquals, Rails/WhereExists, and Rails/WhereNot cops aware of safe navigation operator. (@​koic)

Changes

RuboCop Rails 2.22.2

Bug fixes

  • #1172: Fix an error for Rails/UnknownEnv when using Rails 7.1. (@​koic)
  • #1173: Fix an error for Rails/RedundantActiveRecordAllMethod cop when used with RuboCop 1.51 or lower. (@​koic)

Changes

  • #1171: Change Rails/RedundantActiveRecordAllMethod to ignore delete_all and destroy_all when receiver is an association. (@​masato-bkn)
  • #1178: Require RuboCop AST 1.30.0+. (@​koic)

RuboCop Rails 2.22.1

Bug fixes

  • #1168: Fix a false positive for Rails/DuplicateAssociation when using duplicate belongs_to associations of same class without other arguments. (@​koic)

... (truncated)

Changelog

Sourced from rubocop-rails's changelog.

2.23.1 (2023-12-25)

Bug fixes

  • #1221: Fix an exception in Rails/WhereNot when calling .where on an implicit receiver (e.g. inside model code). ([@​bquorning][])

2.23.0 (2023-12-16)

New features

Bug fixes

  • #1206: Fix an error for Rails/WhereMissing where join method is called without arguments. ([@​fatkodima][])
  • #1189: Fix false negatives for Rails/Pluck when using safe navigation method calls. ([@​koic][])
  • #1204: Make Rails/ActiveSupportAliases, Rails/FindBy, Rails/FindById, Rails/Inquiry, Rails/Pick Rails/PluckId, Rails/PluckInWhere, Rails/WhereEquals, Rails/WhereExists, and Rails/WhereNot cops aware of safe navigation operator. ([@​koic][])

Changes

2.22.2 (2023-11-19)

Bug fixes

  • #1172: Fix an error for Rails/UnknownEnv when using Rails 7.1. ([@​koic][])
  • #1173: Fix an error for Rails/RedundantActiveRecordAllMethod cop when used with RuboCop 1.51 or lower. ([@​koic][])

Changes

  • #1171: Change Rails/RedundantActiveRecordAllMethod to ignore delete_all and destroy_all when receiver is an association. ([@​masato-bkn][])
  • #1178: Require RuboCop AST 1.30.0+. ([@​koic][])

2.22.1 (2023-10-28)

Bug fixes

  • #1145: Fix a false positive for Rails/DuplicateAssociation when using duplicate belongs_to associations of same class without other arguments. ([@​koic][])

2.22.0 (2023-10-27)

New features

  • #906: Add Rails/EnvLocal cop. ([@​sambostock][])
  • #1128: Make Rails/DuplicateAssociation aware of duplicate class_name. ([@​koic][])
  • #1157: Support some Rails 7.1's new querying methods for Rails/RedundantActiveRecordAllMethod. ([@​koic][])
  • #1147: Support the Trilogy adapter for MySQL. ([@​koic][])

... (truncated)

Commits

Updates rubocop-rspec from 2.22.0 to 2.26.1

Release notes

Sourced from rubocop-rspec's releases.

RuboCop RSpec v2.26.1

  • Fix an error for RSpec/SharedExamples when using examples without argument. (@​ydah)

RuboCop RSpec v2.26.0

  • Add new RSpec/RedundantPredicateMatcher cop. (@​ydah)
  • Add new RSpec/RemoveConst cop. (@​swelther)
  • Add support for correcting "it will" (future tense) for RSpec/ExampleWording. (@​jdufresne)
  • Add support for symbol style for RSpec/SharedExamples. (@​jessieay)
  • Ensure PendingWithoutReason can detect violations inside shared groups. (@​robinaugh)

RuboCop RSpec v2.25.0

  • Add support single quoted string and percent string and heredoc for RSpec/Rails/HttpStatus. (@​ydah)
  • Change to be inline disable for RSpec/SpecFilePathFormat like RSpec/FilePath. (@​ydah)
  • Fix a false positive for RSpec/MetadataStyle with example groups having multiple string arguments. (@​franzliedke)

RuboCop RSpec v2.24.1

  • Fix an error when using RSpec/FilePath and revert to enabled by default. If you have already moved to RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat, disable RSpec/FilePath explicitly as Enabled: false. The RSpec/FilePath before migration and the RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat as the target are available respectively. (@​ydah)

RuboCop RSpec v2.24.0

  • Split RSpec/FilePath into RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat. RSpec/FilePath cop is enabled by default, the two new cops are pending and need to be enabled explicitly. (@​ydah)
  • Add new RSpec/Eq cop. (@​ydah)
  • Add RSpec/MetadataStyle and RSpec/EmptyMetadata cops. (@​r7kamura)
  • Add support RSpec/Rails/HttpStatus when have_http_status with string argument. (@​ydah)
  • Fix an infinite loop error when RSpec/ExcessiveDocstringSpacing finds a description with non-ASCII leading/trailing whitespace. (@​bcgraham)
  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when return values declared between stubs. (@​marocchino)
  • Fix a false positive RSpec/Focus when chained method call and inside define method. (@​ydah)

RuboCop RSpec v2.23.2

  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when method is only non-word character. (@​marocchino)
  • Fix a false positive for RSpec/ReceiveMessages when return with splat. (@​marocchino)

... (truncated)

Changelog

Sourced from rubocop-rspec's changelog.

2.26.1 (2024-01-05)

  • Fix an error for RSpec/SharedExamples when using examples without argument. ([@​ydah])

2.26.0 (2024-01-04)

  • Add new RSpec/RedundantPredicateMatcher cop. ([@​ydah])
  • Add new RSpec/RemoveConst cop. ([@​swelther])
  • Add support for correcting "it will" (future tense) for RSpec/ExampleWording. ([@​jdufresne])
  • Add support for symbol style for RSpec/SharedExamples. ([@​jessieay])
  • Ensure PendingWithoutReason can detect violations inside shared groups. ([@​robinaugh])

2.25.0 (2023-10-27)

  • Add support single quoted string and percent string and heredoc for RSpec/Rails/HttpStatus. ([@​ydah])
  • Change to be inline disable for RSpec/SpecFilePathFormat like RSpec/FilePath. ([@​ydah])
  • Fix a false positive for RSpec/MetadataStyle with example groups having multiple string arguments. ([@​franzliedke])

2.24.1 (2023-09-23)

  • Fix an error when using RSpec/FilePath and revert to enabled by default. If you have already moved to RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat, disable RSpec/FilePath explicitly as Enabled: false. The RSpec/FilePath before migration and the RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat as the target are available respectively. ([@​ydah])

2.24.0 (2023-09-08)

  • Split RSpec/FilePath into RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat. RSpec/FilePath cop is disabled by default and the two new cops are pending and need to be enabled explicitly. ([@​ydah])
  • Add new RSpec/Eq cop. ([@​ydah])
  • Add RSpec/MetadataStyle and RSpec/EmptyMetadata cops. ([@​r7kamura])
  • Add support RSpec/Rails/HttpStatus when have_http_status with string argument. ([@​ydah])
  • Fix an infinite loop error when RSpec/ExcessiveDocstringSpacing finds a description with non-ASCII leading/trailing whitespace. ([@​bcgraham])
  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when return values declared between stubs. ([@​marocchino])
  • Fix a false positive RSpec/Focus when chained method call and inside define method. ([@​ydah])

2.23.2 (2023-08-09)

  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when method is only non-word character. ([@​marocchino])
  • Fix a false positive for RSpec/ReceiveMessages when return with splat. ([@​marocchino])

2.23.1 (2023-08-07)

  • Mark to Safe: false for RSpec/Rails/NegationBeValid cop. ([@​ydah])
  • Declare autocorrect as unsafe for RSpec/ReceiveMessages. ([@​bquorning])

2.23.0 (2023-07-30)

  • Add new RSpec/Rails/NegationBeValid cop. ([@​ydah])
  • Fix a false negative for RSpec/ExcessiveDocstringSpacing when finds description with em space. ([@​ydah])
  • Fix a false positive for RSpec/EmptyExampleGroup when example group with examples defined in if branch inside iterator. ([@​ydah])
  • Update the message output of RSpec/ExpectActual to include the word 'value'. ([@​corydiamand])
  • Fix a false negative for RSpec/Pending when it without body. ([@​ydah])
  • Add new RSpec/ReceiveMessages cop. ([@​ydah])

... (truncated)

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [rubocop-govuk](https://github.com/alphagov/rubocop-govuk), [rubocop-rails](https://github.com/rubocop/rubocop-rails) and [rubocop-rspec](https://github.com/rubocop/rubocop-rspec). These dependencies needed to be updated together.

Updates `rubocop-govuk` from 4.12.0 to 4.14.0
- [Changelog](https://github.com/alphagov/rubocop-govuk/blob/main/CHANGELOG.md)
- [Commits](alphagov/rubocop-govuk@v4.12.0...v4.14.0)

Updates `rubocop-rails` from 2.20.2 to 2.23.1
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.20.2...v2.23.1)

Updates `rubocop-rspec` from 2.22.0 to 2.26.1
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rspec@v2.22.0...v2.26.1)

---
updated-dependencies:
- dependency-name: rubocop-govuk
  dependency-type: direct:development
  update-type: version-update:semver-minor
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
- dependency-name: rubocop-rspec
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from eddieleeper as a code owner February 7, 2024 01:33
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants