Authenticate with the Storage Container to upload Playwright reports #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrizzlyOwl
had a problem deploying
to
development
GitHub Actions
Failure
DrizzlyOwl
force-pushed
the
github-workflows-azure-storage
branch
from
d112832 to
e8bcecc
Compare
DrizzlyOwl
had a problem deploying
to
development
GitHub Actions
Failure
DrizzlyOwl
force-pushed
the
github-workflows-azure-storage
branch
from
e8bcecc to
b745013
Compare
DrizzlyOwl
had a problem deploying
to
development
GitHub Actions
Failure
DrizzlyOwl
force-pushed
the
github-workflows-azure-storage
branch
from
b745013 to
5151ba4
Compare
DrizzlyOwl
force-pushed
the
github-workflows-azure-storage
branch
from
5151ba4 to
2804f98
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
DrizzlyOwl
force-pushed
the
github-workflows-azure-storage
branch
from
2804f98 to
cb5a2a1
Compare
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
force-pushed
the
github-workflows-azure-storage
branch
from
cb5a2a1 to
7c03f2e
Compare
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
force-pushed
the
github-workflows-azure-storage
branch
from
7c03f2e to
929532b
Compare
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
force-pushed
the
github-workflows-azure-storage
branch
from
a189767 to
8f6f618
Compare
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
force-pushed
the
github-workflows-azure-storage
branch
from
8f6f618 to
056d049
Compare
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
force-pushed
the
github-workflows-azure-storage
branch
from
05dc9da to
bc27156
Compare
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
Stretch96
requested changes
Oct 23, 2023
DrizzlyOwl
force-pushed
the
github-workflows-azure-storage
branch
from
bc27156 to
61a20b2
Compare
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
force-pushed
the
github-workflows-azure-storage
branch
from
61a20b2 to
79f3396
Compare
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
Stretch96
approved these changes
Oct 25, 2023
DrizzlyOwl
force-pushed
the
github-workflows-azure-storage
branch
from
79f3396 to
bd618e5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding an extra step onto the deployment tests workflow allows us to push playwright reports discreetly onto Azure Blob Storage without holding any artefacts in GitHub workflows.
This is necessary because if a playwright test fails, it will include any and all HTML
POSTed values, which includes the potential of a username/password combination. We dont want that to be exposed in public CI artefacts.The CI workflow authenticates using a Service Principal which has authority to act on the Storage Account.
The Terraform also outputs a SAS URL which allows humans to connect to the Storage Container using something like Azure Storage Explorer to read the playwright reports if they don't have direct access via the Azure Portal.