Docker initcontainer #692
Open
Docker initcontainer #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrizzlyOwl
requested review from
Stretch96,
dneed-nimble,
dynamictulip and
nwarms
as code owners
dynamictulip
reviewed
Jan 7, 2025
dynamictulip
reviewed
Jan 7, 2025
dynamictulip
reviewed
Jan 7, 2025
| RUN ["tdnf", "install", "-y", "mssql-tools18"] | ||
| RUN ["tdnf", "clean", "all"] | ||
| ### Entity Framework: Migration Builder ### | ||
| FROM build AS efbuilder |
There was a problem hiding this comment.
This efbuilder stage should be entirely independent to the build stage so it doesn't need to be re-run when an unrelated file changes
There was a problem hiding this comment.
As far as I understand it, the EF migration bundle command relies on the dotnet restore and build stage to have completed first. Allowing EF Builder to inherit the docker layer means it only has to be done once.
If we do not use the EF Migration bundle and instead just use the SQL Script file then we can likely refactor this to make it leaner
DrizzlyOwl
force-pushed
the
docker-initcontainer
branch
from
6f5b663 to
f93bbd3
Compare
* This entrypoint script will run both the academies db and the fiat db migrations using EF
* Generated an executable Entity Framework migration bundle that can be run as a standalone container
* This means we can build and test both the final runtime image but also the EF migration image used in the initContainer
DrizzlyOwl
force-pushed
the
docker-initcontainer
branch
from
f3ffd81 to
4bf8547
Compare
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
|
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new stage to the Dockerfile which allows us to isolate the Entity Framework database migrations.
When the
initcontainerstage is built independently, it will allow us to run the EF migrations as an initContainer for the main web app