Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: Fake db improvements #466

Closed
wants to merge 7 commits into from
Closed

Maintenance: Fake db improvements #466

wants to merge 7 commits into from

Conversation

dynamictulip
Copy link
Collaborator

Improvements to fake data generation and isolated environment

Changes

  • Add establishment name to groupLinks
  • Update sql scripts
  • Add logging to sql scripts
  • Format generated INSERT script
  • Make running faker locally update the sql scripts without need for manual copy and paste

Checklist

Pull request attached to the appropriate user story in Azure DevOps
ADR decision log updated (if needed)
Release notes added to CHANGELOG.md

  • Testing complete - all manual and automated tests pass

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@DrizzlyOwl DrizzlyOwl mentioned this pull request Sep 3, 2024
Closed
@dynamictulip
Copy link
Collaborator Author

As the hard coded data had to be updated via SQL and not the fake data generator at all, the approach has changed. This PR is superseded by #479

@dynamictulip dynamictulip deleted the fake-db-improvements branch September 16, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dynamictulip