-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Data Protection services #460
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dynamictulip
had a problem deploying
to
development
August 22, 2024 16:57 — with
GitHub Actions
Failure
dynamictulip
temporarily deployed
to
development
August 22, 2024 16:57 — with
GitHub Actions
Inactive
dynamictulip
temporarily deployed
to
development
August 22, 2024 17:01 — with
GitHub Actions
Inactive
dynamictulip
temporarily deployed
to
development
August 22, 2024 17:02 — with
GitHub Actions
Inactive
dynamictulip
temporarily deployed
to
development
August 22, 2024 17:03 — with
GitHub Actions
Inactive
dynamictulip
temporarily deployed
to
development
August 22, 2024 17:04 — with
GitHub Actions
Inactive
dynamictulip
temporarily deployed
to
development
August 27, 2024 10:13 — with
GitHub Actions
Inactive
DrizzlyOwl
force-pushed
the
feature/data-protection-aspnet
branch
from
August 30, 2024 09:53
5494ade
to
ddff33c
Compare
DrizzlyOwl
had a problem deploying
to
development
August 30, 2024 09:53 — with
GitHub Actions
Failure
DrizzlyOwl
had a problem deploying
to
development
August 30, 2024 09:55 — with
GitHub Actions
Failure
DrizzlyOwl
force-pushed
the
feature/data-protection-aspnet
branch
from
September 2, 2024 11:14
e2bdd6d
to
ccbe845
Compare
DrizzlyOwl
had a problem deploying
to
development
September 2, 2024 11:14 — with
GitHub Actions
Failure
DrizzlyOwl
had a problem deploying
to
development
September 2, 2024 11:14 — with
GitHub Actions
Failure
DrizzlyOwl
temporarily deployed
to
development
September 2, 2024 12:51 — with
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
September 2, 2024 12:53 — with
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
September 2, 2024 12:54 — with
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
September 2, 2024 12:55 — with
GitHub Actions
Inactive
DrizzlyOwl
force-pushed
the
feature/data-protection-aspnet
branch
from
September 2, 2024 16:16
cd3eb73
to
f9b509e
Compare
DrizzlyOwl
temporarily deployed
to
development
September 2, 2024 16:16 — with
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
September 2, 2024 16:16 — with
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
September 2, 2024 16:16 — with
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
September 2, 2024 16:17 — with
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
September 2, 2024 16:19 — with
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
September 2, 2024 16:20 — with
GitHub Actions
Inactive
dneed-nimble
approved these changes
Sep 3, 2024
* When running the app across multiple containers it is important to ensure that the session key ring is persistent across instances. Storing the key.xml on a shared filesystem ensures all instances of the app can use the same key ring. * Using an Azure Key Vault Key, the keys.xml can be encrypted at rest further improving the security of the stored key ring
DrizzlyOwl
force-pushed
the
feature/data-protection-aspnet
branch
from
September 3, 2024 14:51
f9b509e
to
8df6909
Compare
DrizzlyOwl
temporarily deployed
to
development
September 3, 2024 14:51 — with
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
September 3, 2024 14:51 — with
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
September 3, 2024 14:51 — with
GitHub Actions
Inactive
Quality Gate passedIssues Measures |
DrizzlyOwl
temporarily deployed
to
development
September 3, 2024 14:53 — with
GitHub Actions
Inactive
DrizzlyOwl
temporarily deployed
to
development
September 3, 2024 14:54 — with
GitHub Actions
Inactive
DrizzlyOwl
had a problem deploying
to
development
September 3, 2024 14:56 — with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this Pull Request is to add aspnet Data Protection services to the webapp. This will ensure that user sessions are secured and persistent across multiple 'instances' of the web app. This is particularly important in Azure where the app is running in containers.
As you will see in the logic of the patch, this is not testable on a local machine due to requiring access to a linux file path and Azure Key Vault Key.
Mounting a network-attached File Share to all the containers that run the app, then storing the session key ring
key.xml
on the shared file path, will ensure all instances of the app can use the same key for encrypting/decrypting user sessions.NB. Changes to
DfE.FindInformationAcademiesTrusts.csproj
were done bydotnet
CLI when adding the new packages. The diff shows spacing on otherwise untouched lines. I would suggest this is a discrepancy between what the CLI does and what Visual Studio does.Changes
Checklist