Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable app insights on the client #179

Closed
wants to merge 18 commits into from
Closed

Enable app insights on the client #179

wants to merge 18 commits into from

Conversation

nwarms
Copy link
Collaborator

@nwarms nwarms commented Oct 16, 2023

User Story 139068: Build: connect App Insights to our Test or Dev environment
Enable client side telemetry to be sent to application insights. We are now tracking page view in addition to the requests we were already tracking.

Changes

Moved App insights initializer so it can be enabled in development mode. This means that developers can track events when running locally. This can be enabled or disabled by putting the connection string into the secrets file or by setting is as an environment variable.
Updated the Content security policy to allow for app insights script to load and for telemetry to be sent back to app insights.
Add the snippet to the layout to load it onto all files.

Checklist

  • Deploy this branch to the test environment for manual testing once comments have been resolved and checks have passed
  • Attach this pull request to the appropriate user story in Azure DevOps
  • Update the ADR decision log if needed

Now we enable and disable app insights using the presence of the connection string in the secrets file
@nwarms nwarms temporarily deployed to development October 16, 2023 10:37 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 16, 2023 10:40 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 16, 2023 10:59 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 16, 2023 11:02 — with GitHub Actions Inactive
@nwarms nwarms requested a review from dynamictulip October 16, 2023 11:21
@dynamictulip dynamictulip temporarily deployed to development October 16, 2023 13:15 — with GitHub Actions Inactive
@dynamictulip dynamictulip temporarily deployed to development October 16, 2023 13:17 — with GitHub Actions Inactive
@dynamictulip
Copy link
Collaborator

dynamictulip commented Oct 16, 2023

Code looks good, needs security test to be run before merge

EDIT - Given the OWASP tests aren't working at the moment (and this change won't go to prod without them having been run) we should be ok to skip running the tests

@nwarms nwarms force-pushed the enable-app-insights branch from 126cc48 to 22447a7 Compare October 17, 2023 09:41
@nwarms nwarms temporarily deployed to development October 17, 2023 09:42 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 17, 2023 09:44 — with GitHub Actions Inactive
Now we enable and disable app insights using the presence of the connection string in the secrets file
@nwarms nwarms force-pushed the enable-app-insights branch from 22447a7 to 1b0be7c Compare October 17, 2023 16:09
dynamictulip
dynamictulip previously approved these changes Oct 17, 2023
@nwarms nwarms temporarily deployed to development October 17, 2023 16:13 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 17, 2023 16:15 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 18, 2023 11:37 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 18, 2023 11:39 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 18, 2023 11:48 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 18, 2023 11:51 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to test October 19, 2023 10:19 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to test October 19, 2023 10:21 — with GitHub Actions Inactive
@nwarms nwarms requested a review from dynamictulip October 19, 2023 12:39
@nwarms nwarms temporarily deployed to development October 19, 2023 12:41 — with GitHub Actions Inactive
@nwarms nwarms temporarily deployed to development October 19, 2023 12:44 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nwarms
Copy link
Collaborator Author

nwarms commented Oct 20, 2023

Closing and reopening on fixed branch

@nwarms nwarms closed this Oct 20, 2023
@dynamictulip dynamictulip deleted the enable-app-insights branch October 23, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants