Set TrustProvider to use academies db instead of academies api
#175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dynamictulip
temporarily deployed
to
development
GitHub Actions
Inactive
dynamictulip
temporarily deployed
to
development
GitHub Actions
Inactive
These new mocks allow methods using async EF core to be mocked
…mies API TrustProvider
Also change `TrustSearch` to use new async-compatible mocks
the GroupUid will be used as the primary reference number when retrieving trusts. ukprn will still be a value returned and references to it will remain, just not used as a primary key.
We want to keep our language in the web project consistent with that of our users in order to make the system easier to maintain - we'd started to drift already with `GroupUid`, `Uid` and `TrustId` all meaning the same thing. `GroupUid` is language specific to the academies database so we will keep it there and use `Uid` in all other scenarios. Also refactored `SearchModelTests`
dynamictulip
force-pushed
the
academies-db-connection/trust-provider
branch
from
426fb0a to
3c803f7
Compare
dynamictulip
temporarily deployed
to
development
GitHub Actions
Inactive
dynamictulip
temporarily deployed
to
development
GitHub Actions
Inactive
|
Kudos, SonarCloud Quality Gate passed! |
lookupdaily
approved these changes
Oct 16, 2023
dynamictulip
merged commit be71dee
into
academies-db-connection-feature
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partly implements User Story 134572: Build: Connect to Academies DB. It removes the last use of the academies API and makes the system entirely use the academies db instead.
Removing redundant academies api classes will be a separate PR.
Changes
ITrustProvidertoDfE.FindInformationAcademiesTrusts.DataprojectTrustProviderthat calls the academies apiTrustProviderthat transforms groups from the academies dbUkprntoUidTrustSearch.SearchAsyncto be properly asynchronousScreenshots of UI changes
No UI changes