fixed comments raised in review

fixed broken playwright test
DFE-Digital · Jan 30, 2024 · 3cb9c92 · 3cb9c92
1 parent a80675b
commit 3cb9c92
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 27 deletions.
diff --git a/tests/DFE.FindInformationAcademiesTrusts.CypressTests/.eslintrc.json b/tests/DFE.FindInformationAcademiesTrusts.CypressTests/.eslintrc.json
@@ -1,21 +1,21 @@
 {
-    "parser": "@typescript-eslint/parser",
-    "plugins": [
-      "cypress"
-    ],
-    "rules": {
-      "cypress/no-assigning-return-values": "warn",
-      "cypress/no-unnecessary-waiting": "warn",
-      "cypress/assertion-before-screenshot": "warn",
-      "cypress/no-force": "warn",
-      "cypress/no-async-tests": "warn",
-      "cypress/no-pause": "warn",
-      "cypress/unsafe-to-chain-command": "warn"
-    },
-    "env": {
-      "cypress/globals": true
-    },
-    "extends": [
-      "plugin:cypress/recommended"
-    ]
-  }
+  "parser": "@typescript-eslint/parser",
+  "plugins": [
+    "cypress"
+  ],
+  "rules": {
+    "cypress/no-assigning-return-values": "warn",
+    "cypress/no-unnecessary-waiting": "warn",
+    "cypress/assertion-before-screenshot": "warn",
+    "cypress/no-force": "warn",
+    "cypress/no-async-tests": "warn",
+    "cypress/no-pause": "warn",
+    "cypress/unsafe-to-chain-command": "warn"
+  },
+  "env": {
+    "cypress/globals": true
+  },
+  "extends": [
+    "plugin:cypress/recommended"
+  ]
+}
diff --git a/tests/DFE.FindInformationAcademiesTrusts.CypressTests/cypress.config.ts b/tests/DFE.FindInformationAcademiesTrusts.CypressTests/cypress.config.ts
@@ -18,7 +18,7 @@ export default defineConfig({
       json: true,
     },
   },
-	userAgent: 'FindInformationAcademiesTrusts/1.0 Cypress',
+  userAgent: 'FindInformationAcademiesTrusts/1.0 Cypress',
   e2e: {
     // We've imported your old cypress plugins here.
     // You may want to clean this up later by importing these.
@@ -30,7 +30,7 @@ export default defineConfig({
       })
 
       on('after:run', async () => {
-        if(process.env.ZAP) {
+        if (process.env.ZAP) {
           await generateZapReport()
         }
       })

diff --git a/tests/DFE.FindInformationAcademiesTrusts.CypressTests/cypress/e2e/regression/cookies.cy.ts b/tests/DFE.FindInformationAcademiesTrusts.CypressTests/cypress/e2e/regression/cookies.cy.ts
@@ -14,7 +14,7 @@ describe("Testing cookies on the site", () => {
 
         cookiesBanner
             .accept()
-            .notVisible();
+            .isNotVisible();
 
         Logger.log("Upon accepting the banner it should stay on the same page");
         cy.url().should("include", "/privacy");
@@ -48,7 +48,7 @@ describe("Testing cookies on the site", () => {
 
         cookiesBanner
             .reject()
-            .notVisible();
+            .isNotVisible();
 
         footerLinks.viewCookies();
 

diff --git a/tests/DFE.FindInformationAcademiesTrusts.CypressTests/cypress/pages/cookiesBanner.ts b/tests/DFE.FindInformationAcademiesTrusts.CypressTests/cypress/pages/cookiesBanner.ts
@@ -1,5 +1,3 @@
-import { Logger } from "../common/logger";
-
 class CookiesBanner {
     public accept(): this {
         cy.getByTestId("banner-accept-analytics-cookies-button").click();
@@ -20,7 +18,7 @@ class CookiesBanner {
         return this;
     }
 
-    public notVisible(): this {
+    public isNotVisible(): this {
         cy.getByTestId("cookies-banner").should("not.exist");
 
         return this;

diff --git a/tests/playwright/fake-data/trusts.json b/tests/playwright/fake-data/trusts.json
@@ -25775,5 +25775,12 @@
       "email": "[email protected]"
     },
     "status": "Open"
+  },
+  {
+    "uid": "1313",
+    "name": "The empty trust",
+    "groupId": "TR3943",
+    "type": "Single-academy trust",
+    "academies": []
   }
 ]