Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER-1010 Formatting and Behaviour issues related to 404 Not found page #780

Merged
merged 8 commits into from
Apr 29, 2024

Conversation

martikat
Copy link
Contributor

@martikat martikat commented Apr 25, 2024

ER-1010

These changes include the contents of the ticket and also changes following QA for HfEYP:

  • Blue hero header for not found should not show
  • Show not found page when incorrect url is used (for third tier)
  • Update font size for mobile text in Contents list
  • Update for padding under mobile menu (tier 2 page)
  • Cookie banner - ensure link in notice navigates to the correct page

@martikat martikat added this to the rc2.0.0 milestone Apr 25, 2024
app/views/pages/side_nav.slim Show resolved Hide resolved
config/locales/en.yml Show resolved Hide resolved
@martikat martikat marked this pull request as ready for review April 26, 2024 10:21
@martikat martikat added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit 18300e4 Apr 29, 2024
2 checks passed
@peterdavidhamilton peterdavidhamilton deleted the ER-1010-bug-fixes branch April 29, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants