Add Dockerfile.azure with SSH, remove CONTAINER_ID and cms constraint #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebrett
force-pushed
the
ER-781-create-git-hub-actions-workflow-dev-subscription
branch
2 times, most recently
from
ea680e4 to
f2f4c6b
Compare
- CONTAINER_ID was only used for Google Optimize, which is discontinued - SSH will be needed for ongoing maintenance by developers see https://learn.microsoft.com/en-gb/azure/app-service/configure-custom-container?tabs=alpine&pivots=container-linux#enable-ssh
ebrett
force-pushed
the
ER-781-create-git-hub-actions-workflow-dev-subscription
branch
from
f2f4c6b to
b05dc19
Compare
|
@peterdavidhamilton @jack-coggin @sunny-sidhu-and I am able to SSH onto the machine now with this PR. However, the review app creation is broken. Holding off on merging this for now, but let's discuss on Monday. In the meantime, please take a look and let me know if you think it looks alright. |
ebrett
requested review from
peterdavidhamilton,
sunny-sidhu-and and
jack-coggin
ebrett
force-pushed
the
ER-781-create-git-hub-actions-workflow-dev-subscription
branch
from
c56b58f to
338a5d4
Compare
ebrett
force-pushed
the
ER-781-create-git-hub-actions-workflow-dev-subscription
branch
from
338a5d4 to
a23c317
Compare
ebrett
force-pushed
the
ER-781-create-git-hub-actions-workflow-dev-subscription
branch
from
a23c317 to
70310df
Compare
ebrett
force-pushed
the
ER-781-create-git-hub-actions-workflow-dev-subscription
branch
from
5bb7a18 to
8177a7c
Compare
ebrett
force-pushed
the
ER-781-create-git-hub-actions-workflow-dev-subscription
branch
from
19f7ff1 to
866437d
Compare
ebrett
changed the title
ebrett
changed the title
ebrett
force-pushed
the
ER-781-create-git-hub-actions-workflow-dev-subscription
branch
from
038623d to
0e7e25a
Compare
ebrett
force-pushed
the
ER-781-create-git-hub-actions-workflow-dev-subscription
branch
from
0e7e25a to
17e98e0
Compare
ebrett
force-pushed
the
ER-781-create-git-hub-actions-workflow-dev-subscription
branch
from
17e98e0 to
ab114b4
Compare
ebrett
force-pushed
the
ER-781-create-git-hub-actions-workflow-dev-subscription
branch
from
ab114b4 to
866437d
Compare
sunny-sidhu-and
approved these changes
Oct 23, 2023
ebrett
deleted the
ER-781-create-git-hub-actions-workflow-dev-subscription
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ER-781]
cmsconstraint on applicationsee https://learn.microsoft.com/en-gb/azure/app-service/configure-custom-container?tabs=alpine&pivots=container-linux#enable-ssh