ER 782 Create app service to host web application dev subscription #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Created review web app at https://eyfs-review-pr-653.london.cloudapps.digital and cms app https://eyfs-cms-review-pr-653.london.cloudapps.digital |
ebrett
force-pushed
the
ER-782-create-app-service-to-host-web-application-dev-subscription
branch
10 times, most recently
from
57c14dc to
11fcd94
Compare
- terraform azure network - terraform azure database - terraform azure web
ebrett
force-pushed
the
ER-782-create-app-service-to-host-web-application-dev-subscription
branch
from
11fcd94 to
d91b141
Compare
sunny-sidhu-and
approved these changes
Oct 4, 2023
| push: | ||
| branches: | ||
| - main | ||
| paths-ignore: |
There was a problem hiding this comment.
The array of files to ignore might want looking at. Some of these files don't exist in this project and should be removed but others might also need to be added in their place.
There was a problem hiding this comment.
Good catch. Agree on this point.
There was a problem hiding this comment.
I did look at them and removed the ones below - the ones I kept were either there or could be added but should probably still be ignored.
- .pa11yci
- uml/*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket and context
[ER-782] Get the webapp up