Address bugs from QA

DFE-Digital · Apr 25, 2024 · ec04608 · ec04608
1 parent 917790c
commit ec04608
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/app/controllers/pages_controller.rb b/app/controllers/pages_controller.rb
@@ -9,7 +9,11 @@ def index
   end
 
   def show
-    render page.to_partial_path
+    if page.nil?
+      render 'errors/not_found'
+    else
+      render page.to_partial_path
+    end
   end
 
 private

diff --git a/app/views/pages/side_nav.slim b/app/views/pages/side_nav.slim
@@ -5,7 +5,7 @@
   = render partial: 'hero', locals: { hero: page.hero }
 
 .govuk-grid-row
-  .govuk-grid-column-one-quarter.sticky.mob-section 
+  .govuk-grid-column-one-quarter.sticky.mob-section class='govuk-!-margin-bottom-4'
     input#menu-icon-chk.menu-btn[type="checkbox" name="menu-icon" checked]
     label.menu-icon.govuk-body-l[for="menu-icon-chk"]
       svg[xmlns="http://www.w3.org/2000/svg" height="1em" viewbox="0 0 448 512"]

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -134,4 +134,4 @@ en:
               blank: Last name must not be blank
   settings:
     cookie_policy_legend: Do you want to accept analytics cookies?
-    preferences_saved_html: Your cookie settings were saved</br><a class='govuk-link' href='%{return_url}'>Go back to Help for early years providers</a>
+    preferences_saved_html: Your cookie settings were saved. [Go back to Help for early years providers](%{return_url}).