Skip to content

Commit

Permalink
Update PR template
Browse files Browse the repository at this point in the history
  • Loading branch information
ebrett committed Oct 9, 2023
1 parent 350a9f9 commit a9b3608
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 22 deletions.
13 changes: 1 addition & 12 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,4 @@
## Ticket and context

Ticket: [HFEYP-###](https://dfedigital.atlassian.net/browse/HFEYP-###)
## Tech review
Ticket: [ER-###](https://dfedigital.atlassian.net/browse/ER-###)

### Is there anything that the code reviewer should know?

### Code quality checks
- [ ] All commit messages are meaningful and true

## Product review

### How can someone see it in review app?
1. Click the link to review app (posted by a `github-actions` bot below)
2. Follow the steps from the ticket.
15 changes: 5 additions & 10 deletions .github/workflows/tf-azure-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,25 +75,20 @@ jobs:
jq 'with_entries(.key |= ascii_downcase)' tmp-secrets.json > web-secrets.auto.tfvars.json
jq 'with_entries(.key |= ascii_downcase)' tmp-vars.json > web-vars.auto.tfvars.json
- name: Terraform import
id: tf-import
run: >
terraform import azurerm_resource_group.rg /subscriptions/***/resourceGroups/s195d01-hfeyp-rg
# Generates an execution plan for Terraform
# An exit code of 0 indicated no changes, 1 a terraform failure, 2 there are pending changes.
- name: Terraform Plan
id: tf-plan
run: |
export exitcode=0
terraform plan -detailed-exitcode -no-color -out tfplan || export exitcode=$?
echo "exitcode=$exitcode" >> $GITHUB_OUTPUT
if [ $exitcode -eq 1 ]; then
echo Terraform Plan Failed!
exit 1
else
else
exit 0
fi
Expand All @@ -109,7 +104,7 @@ jobs:
id: tf-plan-string
run: |
TERRAFORM_PLAN=$(terraform show -no-color tfplan)
delimiter="$(openssl rand -hex 8)"
echo "summary<<${delimiter}" >> $GITHUB_OUTPUT
echo "## Terraform Plan Output" >> $GITHUB_OUTPUT
Expand Down Expand Up @@ -176,4 +171,4 @@ jobs:

# Terraform Apply
- name: Terraform Apply
run: terraform apply -auto-approve tfplan/tfplan
run: terraform apply -auto-approve tfplan/tfplan

0 comments on commit a9b3608

Please sign in to comment.