Skip to content

Commit

Permalink
Update to address PR comments and temporary update for error page and…
Browse files Browse the repository at this point in the history
… citation
  • Loading branch information
martikat committed Apr 16, 2024
1 parent 948c4bb commit 95c8614
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 15 deletions.
9 changes: 0 additions & 9 deletions app/controllers/settings_controller.rb
Original file line number Diff line number Diff line change
@@ -1,13 +1,4 @@
class SettingsController < ApplicationController
def show
if template_valid?
track('static_page')
render template
else
render 'errors/not_found'
end
end

def create
set_cookie_pref

Expand Down
6 changes: 3 additions & 3 deletions app/views/errors/not_found.html.slim
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@
h1.govuk-heading-xl Page not found

p.govuk-body
| Use this link to go back to the homepage
| Use this link to go back to the homepage
= govuk_link_to 'Help for early years providers', root_path

p.govuk-body
| If the web address is correct or you selected a link or button, contact
| If the web address is correct or you selected a link or button, contact
= govuk_link_to '[email protected]', 'mailto:[email protected]'
| to report a fault about the service.
| to report a fault about the service.
2 changes: 1 addition & 1 deletion app/views/pages/default.html.slim
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
.govuk-grid-column-full
= m(page.body)

= render 'shared/citation'
/ = render 'shared/citation'
- if page.content_list.present?
= render 'shared/back_to_top'
Expand Down
2 changes: 1 addition & 1 deletion app/views/pages/index.html.slim
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

= m(page.body)

if page.slug == 'cookie-policy'
- if page.slug == 'cookie-policy'
= render 'settings/cookie_policy'

= render 'shared/ctas'
Expand Down
2 changes: 1 addition & 1 deletion app/views/pages/side_nav.slim
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
= m(page.body)

- if page.content_list.present?
= render 'shared/citation'
/ = render 'shared/citation'
= render 'shared/back_to_top'
= render 'shared/print'

Expand Down

0 comments on commit 95c8614

Please sign in to comment.