Remove old code (#737)

.github/workflows/azure-deploy-prod.yml

@@ -11,9 +11,6 @@ on:
         description: 'Release candidate to deploy ("rcx.x.x")'
         type: string
         required: true
-  push:
-    tags:
-      - v*
 
 # Permissions for OIDC authentication
 permissions:
@@ -97,4 +94,4 @@ jobs:
         with:
           app-name: ${{ vars.WEBAPP_NAME }}
           images: ${{ env.DOCKER_IMAGE }}:${{ inputs.version || github.ref_name }}
-          slot-name: ${{ vars.WEBAPP_DEPLOY_SLOT }}
+          slot-name: ${{ vars.WEBAPP_DEPLOY_SLOT }}

.rubocop.yml

@@ -15,14 +15,6 @@ require: rubocop-performance
 
 AllCops:
   TargetRubyVersion: 3.2.2
-  Exclude:
-    - "**/*.erb"
-    - 'bin/*'
-    - 'db/schema.rb'
-    - 'node_modules/**/*'
-    - 'config/application.rb'
-    - 'config/puma.rb'
-    - 'vendor/**/*'
 
 Style/StringLiterals:
   EnforcedStyle: single_quotes

.rubocop_todo.yml

@@ -1,219 +1,25 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2024-01-16 15:44:08 UTC using RuboCop version 1.59.0.
+# `rubocop --auto-gen-config --no-auto-gen-timestamp`
+# using RuboCop version 1.59.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 5
-# This cop supports safe autocorrection (--autocorrect).
-Capybara/CurrentPathExpectation:
-  Exclude:
-    - 'spec/features/admin/user_admin_page_spec.rb'
-    - 'spec/features/admin_content_pages_spec.rb'
-
-# Offense count: 3
-Capybara/VisibilityMatcher:
-  Exclude:
-    - 'spec/features/admin/user_admin_page_spec.rb'
-    - 'spec/features/admin_content_pages_spec.rb'
-
-# Offense count: 2
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: Include, EnforcedStyle, ExplicitOnly.
-# Include: **/*_spec.rb, **/spec/**/*, **/test/**/*, **/features/support/factories/**/*.rb
-# SupportedStyles: create_list, n_times
-FactoryBot/CreateList:
-  Exclude:
-    - 'spec/views/admin/content_pages/index.html.erb_spec.rb'
-    - 'spec/views/content/index.html.erb_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
-Layout/ExtraSpacing:
-  Exclude:
-    - 'config/initializers/time_formats.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Performance/RedundantMatch:
-  Exclude:
-    - 'e2etests/features/support/common.rb'
-
 # Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: MaxKeyValuePairs.
-Performance/RedundantMerge:
-  Exclude:
-    - 'db/seeds.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Performance/RegexpMatch:
-  Exclude:
-    - 'e2etests/features/support/common.rb'
-
-# Offense count: 4
-# This cop supports safe autocorrection (--autocorrect).
-Performance/StringReplacement:
-  Exclude:
-    - 'app/models/content_page.rb'
-    - 'e2etests/features/support/common.rb'
-
-# Offense count: 1
-RSpec/BeforeAfterAll:
-  Exclude:
-    - 'spec/requests/content_request_spec.rb'
-
-# Offense count: 14
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
 RSpec/ContextWording:
   Exclude:
-    - 'spec/models/content_page_spec.rb'
     - 'spec/models/user_spec.rb'
-    - 'spec/requests/admin/user_request_spec.rb'
-    - 'spec/requests/content_request_spec.rb'
-
-# Offense count: 13
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: SkipBlocks, EnforcedStyle.
-# SupportedStyles: described_class, explicit
-RSpec/DescribedClass:
-  Exclude:
-    - 'spec/models/content_page_spec.rb'
-    - 'spec/models/user_spec.rb'
-
-# Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/EmptyExampleGroup:
-  Exclude:
-    - 'spec/features/user_admin_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowConsecutiveOneLiners.
-RSpec/EmptyLineAfterExample:
-  Exclude:
-    - 'spec/features/admin_content_pages_spec.rb'
-
-# Offense count: 15
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/EmptyLineAfterFinalLet:
-  Exclude:
-    - 'spec/features/admin/user_admin_page_spec.rb'
-    - 'spec/requests/admin/content_blocks_spec.rb'
-    - 'spec/requests/admin/content_page_versions_spec.rb'
-    - 'spec/requests/admin/content_pages_spec.rb'
-    - 'spec/requests/admin/user_request_spec.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowConsecutiveOneLiners.
-RSpec/EmptyLineAfterHook:
-  Exclude:
-    - 'spec/requests/admin/content_pages_spec.rb'
-    - 'spec/requests/feedbacks_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/EmptyLineAfterSubject:
-  Exclude:
-    - 'spec/requests/admin/content_pages_spec.rb'
-
-# Offense count: 4
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: CustomTransform, IgnoredWords, DisallowedExamples.
-# DisallowedExamples: works
-RSpec/ExampleWording:
-  Exclude:
-    - 'spec/features/content_pages_spec.rb'
-    - 'spec/features/drafting_and_publishing_spec.rb'
-    - 'spec/models/content_page_spec.rb'
-    - 'spec/views/content/index.html.erb_spec.rb'
 
 # Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: method_call, block
-RSpec/ExpectChange:
-  Exclude:
-    - 'spec/requests/admin/content_pages_spec.rb'
-
-# Offense count: 5
 # Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
 # Include: **/*_spec*rb*, **/spec/**/*
 RSpec/FilePath:
   Exclude:
-    - 'spec/requests/admin/content_blocks_spec.rb'
-    - 'spec/requests/admin/content_page_versions_spec.rb'
-    - 'spec/requests/admin/content_pages_spec.rb'
-    - 'spec/requests/admin/user_request_spec.rb'
     - 'spec/requests/application_spec.rb'
 
-# Offense count: 7
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: implicit, each, example
-RSpec/HookArgument:
-  Exclude:
-    - 'spec/models/content_page_spec.rb'
-    - 'spec/requests/admin/content_pages_spec.rb'
-    - 'spec/views/admin/content_pages/edit.html.erb_spec.rb'
-    - 'spec/views/admin/content_pages/index.html.erb_spec.rb'
-    - 'spec/views/admin/content_pages/new.html.erb_spec.rb'
-    - 'spec/views/admin/content_pages/show.html.erb_spec.rb'
-    - 'spec/views/content/index.html.erb_spec.rb'
-
-# Offense count: 34
-# Configuration parameters: AssignmentOnly.
-RSpec/InstanceVariable:
-  Exclude:
-    - 'spec/models/content_page_spec.rb'
-    - 'spec/views/admin/content_pages/edit.html.erb_spec.rb'
-    - 'spec/views/admin/content_pages/index.html.erb_spec.rb'
-    - 'spec/views/admin/content_pages/show.html.erb_spec.rb'
-    - 'spec/views/content/index.html.erb_spec.rb'
-
-# Offense count: 11
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/LeadingSubject:
-  Exclude:
-    - 'spec/requests/admin/content_blocks_spec.rb'
-    - 'spec/requests/admin/content_page_versions_spec.rb'
-    - 'spec/requests/admin/content_pages_spec.rb'
-    - 'spec/requests/admin/user_request_spec.rb'
-    - 'spec/requests/feedbacks_spec.rb'
-
-# Offense count: 74
-# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
-# SupportedStyles: always, named_only
-RSpec/NamedSubject:
-  Exclude:
-    - 'spec/requests/admin/content_blocks_spec.rb'
-    - 'spec/requests/admin/content_page_versions_spec.rb'
-    - 'spec/requests/admin/content_pages_spec.rb'
-    - 'spec/requests/admin/user_request_spec.rb'
-    - 'spec/requests/feedbacks_spec.rb'
-
-# Offense count: 5
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: not_to, to_not
-RSpec/NotToNot:
-  Exclude:
-    - 'spec/models/content_page_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: numeric, symbolic, be_status
-RSpec/Rails/HttpStatus:
-  Exclude:
-    - 'spec/requests/errors_page_request_spec.rb'
-
 # Offense count: 1
 RSpec/StubbedMock:
   Exclude:
@@ -224,24 +30,3 @@ RSpec/StubbedMock:
 RSpec/VerifiedDoubles:
   Exclude:
     - 'spec/lib/rack/reject_trace_spec.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: slashes, arguments
-Rails/FilePath:
-  Exclude:
-    - 'spec/rails_helper.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Style/RedundantFreeze:
-  Exclude:
-    - 'app/models/content_page.rb'
-
-# Offense count: 998
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiterals:
-  Enabled: false

Gemfile

@@ -1,4 +1,4 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
 ruby '3.2.2'
 
@@ -8,7 +8,7 @@ gem 'audited', '~> 5.4'
 gem 'bcrypt', '~> 3.1.16'
 gem 'bootsnap', '>= 1.17.1', require: false
 gem 'canonical-rails', '~> 0.2'
-gem "contentful_rails", "~> 0.5.0"
+gem 'contentful_rails', '~> 0.5.0'
 gem 'cssbundling-rails'
 gem 'devise', '>= 4.9.3'
 gem 'devise-security', '~> 0.18.0'
@@ -18,21 +18,18 @@ gem 'dry-initializer'
 gem 'dry-struct'
 gem 'dry-types'
 gem 'friendly_id', '~> 5.5'
-gem 'govspeak', '~> 8.3'
 gem 'govuk-components'
 gem 'govuk_design_system_formbuilder'
-gem 'govuk_markdown', '~> 2.0'
-gem 'haml', '~> 5.2'
+gem 'govuk_markdown'
 gem 'htmlentities', '4.3.4'
 gem 'jsbundling-rails'
 gem 'pg', '~> 1.1'
 gem 'puma', '~> 5.6'
-gem 'pundit', '~> 2.1'
 gem 'rails', '~> 7.0.8'
 gem 'sentry-rails'
 gem 'sentry-ruby'
-gem 'slim-rails', '~> 3.6'
-gem "sprockets-rails", "~> 3.4"
+gem 'slim-rails'
+gem 'sprockets-rails', '~> 3.4'
 gem 'turbo-rails'
 gem 'tzinfo-data', platforms: %i[mingw mswin x64_mingw jruby]
 
@@ -52,9 +49,14 @@ group :development, :test do
 end
 
 group :development do
+  gem 'better_errors'
+  gem 'binding_of_caller'
+  gem 'brakeman'
   gem 'listen', '>= 3.0.5', '< 3.8'
+  gem 'pry-doc'
   gem 'rladr'
-  gem 'web-console', '>= 3.3.0'
+  gem 'web-console'
+  gem 'yard-junk'
 end
 
 group :test do