Log session answers to rollbar #3478
Open
+74
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
force-pushed
the
CAPT-1861/log_session_answers
branch
from
98870de to
c642bc0
Compare
Some of the errors in rollbar are tricky to debug as we don't know what answers the claimant provided. This commit adds a mechanism for flagging attributes as PII and updates the ClaimsController to include the non pii attributes in the Rollbar scope such that they are available in Rollbar.
rjlynch
force-pushed
the
CAPT-1861/log_session_answers
branch
from
c642bc0 to
4e32654
Compare
asmega
reviewed
Jan 2, 2025
| end | ||
| end | ||
|
|
||
| def attributes_with_pii_redacted |
There was a problem hiding this comment.
can we add some basic coverage for this method?
slorek
requested changes
Jan 2, 2025
There was a problem hiding this comment.
There is already some config here https://github.com/DFE-Digital/claim-additional-payments-for-teaching/blob/master/app/models/claim.rb#L20 from when the Claim object was built during the journey. It might be that this is now redundant or could be considered as part of this change. I think the list of filtered attributes should be managed in one place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the errors in rollbar are tricky to debug as we don't know what
answers the claimant provided. This commit adds a mechanism for flagging
attributes as PII and updates the ClaimsController to include the non
pii attributes in the Rollbar scope such that they are available in
Rollbar.
Here are two errors in rollbar showing the additional params sent over https://app.rollbar.com/a/dfe-digital/fix/item/dfe-claims/1530#occurrences
We couldn't reuse the config/analytics_blocklist.yml list for scrubbing pi as journey sessions store all answers in the
answersdb column and we just block the whole column. I think tacking onpii: trueto the attribute definition isn't too much overhead and may end up being useful in other contexts.