CAPT 1797 ops queries alternative implementation #3472
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the model to handle generating the reporting code for further education claims that have been approved but with a failing provider verification.
Adds the controller and views for downloading the ops reports.
One gotcha that we might need to deal with in this report is the `dqt_teacher_status`. When the qualification claim verifier runs is uses the dqt record to set some notes on the claim. If the claim has a populated `dqt_teacher_status` field it uses that to build the dqt teacher record object, if not the status is fetched from the api, however this information from the api is not persisted to the claim. When generating the report we don't want to hit the dqt api for potentially many claims, so if we're missing this dqt status we don't include it in the report. Checking the current academic year's claims there don't seem to be any claims that would be returned from this report that are missing their `dqt_teacher_status`. If missing `dqt_teacher_status` in this report is causing issues for the ops team, we could consider parsing the claim notes to get this information.
Noticed we were missing the csv extension on the report
We're soon going to want to generate a report for the ops team of the duplicate claims. This commit introduces a new claim verifier that records the duplicate claims, if any. Once existing duplicates on production have been back filled we can replace other uses of `MatchingAttributeFinder#matching_claims` with `claim.duplicates` and also join claims to their duplicates when generating the duplicate claims report.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.