Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stricter address validations #3466

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Add stricter address validations #3466

merged 1 commit into from
Dec 23, 2024

Conversation

rjlynch
Copy link
Contributor

@rjlynch rjlynch commented Dec 17, 2024

Updates the address validations to be stricter. We now require at least
a single letter in the street part of the address, only letters and
punctuation in the town / city name (no numbers)

@rjlynch rjlynch added the deploy Deploy a review app for this PR label Dec 17, 2024
@github-actions GitHub Actions
Copy link

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3466-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3466-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3466-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3466-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3466-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3466-web.test.teacherservices.cloud/admin

@rjlynch rjlynch force-pushed the CAPT-2064/stricter-address-validations branch from e61e6d1 to e3823cb Compare December 17, 2024 15:33
@rjlynch rjlynch force-pushed the CAPT-2064/stricter-address-validations branch from e3823cb to eae087a Compare December 17, 2024 15:42
@rjlynch
Add stricter address validations
68cb793 
Updates the address validations to be stricter. We now require at least
a single letter in the street part of the address, only letters and
punctuation in the town / city name (no numbers), and at least a letter
or digit in the house name / number field.
@rjlynch rjlynch force-pushed the CAPT-2064/stricter-address-validations branch from eae087a to 68cb793 Compare December 23, 2024 09:37
@rjlynch rjlynch merged commit 2cd7f30 into master Dec 23, 2024
15 checks passed
@rjlynch rjlynch deleted the CAPT-2064/stricter-address-validations branch December 23, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorek slorek slorek approved these changes

Assignees
No one assigned
Labels
deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjlynch @slorek