Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPT-1953 - Initial attempt to silence repeated unwanted requests #3464

Merged
merged 1 commit into from
Dec 16, 2024
Merged

CAPT-1953 - Initial attempt to silence repeated unwanted requests #3464

merged 1 commit into from
Dec 16, 2024

Conversation

kenfodder
Copy link
Contributor

@kenfodder kenfodder commented Dec 16, 2024 •
edited
Loading

Catch unwanted request patterns to stop to them alerting in Rollbar and force them to be a 404.

Tested in Review App seems to work.

Here are the ones that do come through that are deliberately incorrect:

Screenshot 2024-12-16 at 15 22 22

@kenfodder kenfodder added the deploy Deploy a review app for this PR label Dec 16, 2024
@github-actions GitHub Actions
Copy link

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3464-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3464-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3464-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3464-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3464-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3464-web.test.teacherservices.cloud/admin

@kenfodder kenfodder marked this pull request as ready for review December 16, 2024 15:23
@kenfodder kenfodder requested review from rjlynch and slorek December 16, 2024 15:24
@kenfodder kenfodder force-pushed the CAPT-1953-unwanted-requests-404 branch from 344ed24 to d18243c Compare December 16, 2024 16:57
rjlynch
rjlynch approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kenfodder kenfodder force-pushed the CAPT-1953-unwanted-requests-404 branch from d18243c to b9794f9 Compare December 16, 2024 17:07
@kenfodder kenfodder merged commit 4c91be0 into master Dec 16, 2024
15 checks passed
@kenfodder kenfodder deleted the CAPT-1953-unwanted-requests-404 branch December 16, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

@slorek slorek Awaiting requested review from slorek

Assignees
No one assigned
Labels
deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenfodder @rjlynch