Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp remove analytics syncing #3397

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Temp remove analytics syncing #3397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/csv_importer/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def rows_with_data_count
private

def sync_analytics
AnalyticsImporter.import(target_data_model)
# NOOP
end

def empty_row?(row)
Expand Down
7 changes: 0 additions & 7 deletions spec/lib/csv_importer/base_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,6 @@
end
end

describe "dfe-analytics syncing" do
it "invokes the relevant import entity job" do
expect(AnalyticsImporter).to receive(:import).with(target_data_model)
importer.run
end
end

describe "data transformation and importing" do
before { importer.run }

Expand Down