Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAPT-1911][CAPT-1968] EY submission emails #3385

Merged
merged 2 commits into from
Nov 11, 2024
Merged

[CAPT-1911][CAPT-1968] EY submission emails #3385

merged 2 commits into from
Nov 11, 2024

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Nov 11, 2024 •
edited
Loading

Context

@asmega asmega changed the title Ey provider submitted mail [CAPT-1911][CAPT-1968] EY submission emails Nov 11, 2024
@asmega asmega added the deploy Deploy a review app for this PR label Nov 11, 2024
@github-actions GitHub Actions
Copy link

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3385-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3385-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3385-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3385-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3385-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3385-web.test.teacherservices.cloud/admin

@asmega asmega marked this pull request as ready for review November 11, 2024 11:51
rjlynch
rjlynch approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

app/forms/claim_submission_base_form.rb
@@ -24,7 +24,7 @@ def save
claim.save!
end

ClaimMailer.submitted(claim).deliver_later if claim.submitted_at
claim.policy.mailer.submitted(claim).deliver_later
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Nice

@asmega asmega force-pushed the ey-provider-submitted-mail branch from addb0c5 to 5c40bc4 Compare November 11, 2024 16:54
@asmega asmega merged commit f62de1f into master Nov 11, 2024
14 checks passed
@asmega asmega deleted the ey-provider-submitted-mail branch November 11, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

Assignees
No one assigned
Labels
business reviewed deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmega @rjlynch