LUPEYALPHA 1171/identity task #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
force-pushed
the
LUPEYALPHA-1171/identity-task-1
branch
from
bc25e8b to
65e480c
Compare
rjlynch
added
deploy
rjlynch
force-pushed
the
LUPEYALPHA-1171/identity-task-1
branch
from
65e480c to
b18b869
Compare
rjlynch
force-pushed
the
LUPEYALPHA-1171/identity-task-1
branch
from
b18b869 to
b3d4a64
Compare
rjlynch
changed the title
rjlynch
force-pushed
the
LUPEYALPHA-1171/identity-task-1
branch
2 times, most recently
from
e20cc58 to
a8c1906
Compare
Allow a policy to define it's own view for a specific task. If a policy defines a template `admin/tasks/<policy name>/tasks/<task name>` we'll use that when rendering the task view. If there isn't a policy specific view we'll fall back to the task view in `admin/tasks/<taske name>`.
Previously we were not running the claim verifiers for EY as EY claims don't have a trn. This commit passes in a nil dqt teacher status if the policy doesn't have a trn but still runs the claim verifiers.
This allows us some controller if we want to stub this in our tests
rjlynch
force-pushed
the
LUPEYALPHA-1171/identity-task-1
branch
from
a8c1906 to
dca5334
Compare
rjlynch
force-pushed
the
LUPEYALPHA-1171/identity-task-1
branch
from
dca5334 to
ee28fb4
Compare
rjlynch
force-pushed
the
LUPEYALPHA-1171/identity-task-1
branch
from
ee28fb4 to
e00f8ed
Compare
This task displays differently to other tasks as such we've introduced a separate claim verifier and separate view template.
This is the same warning but it now has a different fingerprint as we've move some of the lines of code around.
rjlynch
force-pushed
the
LUPEYALPHA-1171/identity-task-1
branch
from
e00f8ed to
f4bf844
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be easier to review each commit separately.
The main change in this pr is adding the Identity task.
The EY identity task behaves slightly differently to the other tasks.
EY practitioners don't have DQT records so we're only using the information
from one login to check identity, additionally the rules around creating the
task are slightly different to other policies.
If the one login check passes and the name returned from OL matches the name
the provider entered the task is a pass
If the one login check passes and the names are a partial match¹ then we
create task with a partial match (see Admin::ClaimsHelper#task_status_tag)
If the one login check passes and the name from OL is different to the
provider supplied name we create a failed task.
If the one login check fails we create a failed task.
If the task is a partial match we render the task form for admins to update the
task (either passing or failing it).
Another quirk is if the practitioner hasn't completed their portion of the
journey we don't want to render the task form, and instead we want to show some
copy informing admins the practitioner is yet to complete their journey.
As there's a few differences between how other identity tasks work we've
introduced a separate task view for EY identity tasks.
¹ - we'll be changing the rules around what counts as a partial match in a
separate ticket.