Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LUPEYALPHA-1174] EY employment task #3352

Merged
merged 1 commit into from
Oct 31, 2024
Merged

[LUPEYALPHA-1174] EY employment task #3352

merged 1 commit into from
Oct 31, 2024

Conversation

alkesh
Copy link
Contributor

@alkesh alkesh commented Oct 29, 2024 •
edited
Loading

https://dfedigital.atlassian.net/browse/LUPEYALPHA-1174

changes:

  • update employment admin task, so that it copes with the EY scenario of not being available until a certain date
  • moved various model specs into the correct folders, so they match the module hierarchy

@alkesh alkesh added the deploy Deploy a review app for this PR label Oct 30, 2024
@github-actions GitHub Actions
Copy link

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3352-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3352-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3352-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3352-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3352-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3352-web.test.teacherservices.cloud/admin

@alkesh alkesh force-pushed the LUPEYALPHA-1174-EY-admin-employment-task branch from ca4b0a0 to 514f9ca Compare October 30, 2024 14:42
asmega
asmega reviewed Oct 31, 2024
View reviewed changes
app/models/task.rb Outdated
@@ -53,4 +53,10 @@ def to_param
def identity_confirmation?
name == "identity_confirmation"
end

def available?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i'd prefer to call this method employment_task_available?, even though it's a bit out of place as it's more specific than available? the next person is far less likely to hijack for some other use

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@alkesh alkesh force-pushed the LUPEYALPHA-1174-EY-admin-employment-task branch from 514f9ca to 018daaf Compare October 31, 2024 15:57
@alkesh alkesh requested a review from asmega October 31, 2024 16:45
@alkesh alkesh merged commit d892aa6 into master Oct 31, 2024
17 checks passed
@alkesh alkesh deleted the LUPEYALPHA-1174-EY-admin-employment-task branch October 31, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmega asmega asmega approved these changes

Assignees
No one assigned
Labels
business reviewed deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alkesh @asmega