[LUPEYALPHA-1173][LUPEYALPHA-1176] EY rejection reasons #3350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmega
commented
Oct 29, 2024
Comment on lines
+3
to
+12
| dqt_teacher_status = if claim.policy == Policies::EarlyYearsPayments | ||
| nil | ||
| elsif claim.has_dqt_record? | ||
| Dqt::Teacher.new(claim.dqt_teacher_status) | ||
| else | ||
| Dqt::Client.new.teacher.find( | ||
| claim.eligibility.teacher_reference_number, | ||
| birthdate: claim.date_of_birth.to_s, | ||
| nino: claim.national_insurance_number | ||
| ) |
There was a problem hiding this comment.
this isn't great but will do for now. ideally each automated check should be independent and all called async which is not the case now
asmega
force-pushed
the
ey-rejection-reasons
branch
from
bfe4bac to
bb152c3
Compare
asmega
force-pushed
the
ey-rejection-reasons
branch
from
bb152c3 to
921b94b
Compare
asmega
commented
Oct 29, 2024
| claim_subject: "Early Years Payment" | ||
| policy_acronym: EY | ||
| policy_short_name: Early Years | ||
| policy_full_name: Early years financial incentive payment | ||
| support_email_address: "[email protected]" |
There was a problem hiding this comment.
temporary placeholder till we know what these will be replaced with
asmega
changed the title
alkesh
approved these changes
Oct 31, 2024
asmega
force-pushed
the
ey-rejection-reasons
branch
from
6e1e4f5 to
ddd910f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context