Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAPT-1957] Handle currency for eligble FE CSV upload #3343

Merged
merged 2 commits into from
Nov 7, 2024
Merged

[CAPT-1957] Handle currency for eligble FE CSV upload #3343

merged 2 commits into from
Nov 7, 2024

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Oct 24, 2024 •
edited
Loading

Context

@asmega asmega added the deploy Deploy a review app for this PR label Oct 24, 2024
@github-actions GitHub Actions
Copy link

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3343-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3343-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3343-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3343-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3343-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3343-web.test.teacherservices.cloud/admin

@asmega asmega marked this pull request as ready for review October 24, 2024 12:06
rjlynch
rjlynch approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

rjlynch
rjlynch approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

lib/csv_importer/base.rb
@@ -70,7 +70,8 @@ def parse_csv_file(file)
errors.append("Select a file")
nil
else
CSV.read(file.to_io, headers: parse_headers, encoding: "BOM|UTF-8")
string = File.open(file.path, "r", encoding: "BOM|UTF-8").read.scrub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmega asmega changed the title [LUPEYALPHA-1208] Handle currency for eligble FE CSV upload [CAPT-1957] Handle currency for eligble FE CSV upload Nov 7, 2024
@asmega asmega merged commit f12b220 into master Nov 7, 2024
14 checks passed
@asmega asmega deleted the better-csv branch November 7, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

Assignees
No one assigned
Labels
business reviewed deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmega @rjlynch