-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove batching from payroll csv #3336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
force-pushed
the
CAPT-1870/remove-1000-payroll-limitation
branch
from
October 22, 2024 10:22
16c5604
to
d63c468
Compare
rjlynch
force-pushed
the
CAPT-1870/remove-1000-payroll-limitation
branch
from
October 22, 2024 10:34
d63c468
to
b8e0596
Compare
rjlynch
force-pushed
the
CAPT-1870/remove-1000-payroll-limitation
branch
from
October 22, 2024 10:45
b8e0596
to
620cacc
Compare
rjlynch
force-pushed
the
CAPT-1870/remove-1000-payroll-limitation
branch
from
October 22, 2024 11:10
33603fd
to
5517e80
Compare
rjlynch
force-pushed
the
CAPT-1870/remove-1000-payroll-limitation
branch
from
October 22, 2024 11:55
5517e80
to
0f64a51
Compare
rjlynch
force-pushed
the
CAPT-1870/remove-1000-payroll-limitation
branch
from
October 22, 2024 12:10
0f64a51
to
620cacc
Compare
rjlynch
force-pushed
the
CAPT-1870/remove-1000-payroll-limitation
branch
from
October 22, 2024 13:26
8e44e76
to
620cacc
Compare
rjlynch
force-pushed
the
CAPT-1870/remove-1000-payroll-limitation
branch
from
October 22, 2024 14:04
0cdf505
to
f717ad0
Compare
asmega
approved these changes
Nov 1, 2024
Requirement is to only produce a single payroll file with no limit on the number of payments in the file. This commit removes the zip file as we no longer need it and instead serves the generated csv directly, this lets us simplify the code quite a bit.
Now the payroll run software has been updated we no longer need to limit the number of payments in a payroll run.
rjlynch
force-pushed
the
CAPT-1870/remove-1000-payroll-limitation
branch
from
November 1, 2024 14:14
f717ad0
to
6ed3edd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement is to only produce a single payroll file with no limit on
the number of payments in the file.
This commit removes the zip file as we no longer need it and instead
serves the generated csv directly, this lets us simplify the code quite
a bit.