Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove batching from payroll csv #3336

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

rjlynch
Copy link
Contributor

@rjlynch rjlynch commented Oct 22, 2024

Requirement is to only produce a single payroll file with no limit on
the number of payments in the file.
This commit removes the zip file as we no longer need it and instead
serves the generated csv directly, this lets us simplify the code quite
a bit.

@rjlynch rjlynch added the deploy Deploy a review app for this PR label Oct 22, 2024
@rjlynch rjlynch force-pushed the CAPT-1870/remove-1000-payroll-limitation branch from 16c5604 to d63c468 Compare October 22, 2024 10:22
@rjlynch rjlynch force-pushed the CAPT-1870/remove-1000-payroll-limitation branch from d63c468 to b8e0596 Compare October 22, 2024 10:34
@rjlynch rjlynch force-pushed the CAPT-1870/remove-1000-payroll-limitation branch from b8e0596 to 620cacc Compare October 22, 2024 10:45
@rjlynch rjlynch force-pushed the CAPT-1870/remove-1000-payroll-limitation branch from 33603fd to 5517e80 Compare October 22, 2024 11:10
@rjlynch rjlynch removed the deploy Deploy a review app for this PR label Oct 22, 2024
@rjlynch rjlynch force-pushed the CAPT-1870/remove-1000-payroll-limitation branch from 5517e80 to 0f64a51 Compare October 22, 2024 11:55
@rjlynch rjlynch added the deploy Deploy a review app for this PR label Oct 22, 2024
@rjlynch rjlynch force-pushed the CAPT-1870/remove-1000-payroll-limitation branch from 0f64a51 to 620cacc Compare October 22, 2024 12:10
@rjlynch rjlynch force-pushed the CAPT-1870/remove-1000-payroll-limitation branch from 8e44e76 to 620cacc Compare October 22, 2024 13:26
@rjlynch rjlynch force-pushed the CAPT-1870/remove-1000-payroll-limitation branch from 0cdf505 to f717ad0 Compare October 22, 2024 14:04
@rjlynch rjlynch marked this pull request as ready for review October 29, 2024 15:15
Requirement is to only produce a single payroll file with no limit on
the number of payments in the file.
This commit removes the zip file as we no longer need it and instead
serves the generated csv directly, this lets us simplify the code quite
a bit.
Now the payroll run software has been updated we no longer need to limit
the number of payments in a payroll run.
@rjlynch rjlynch force-pushed the CAPT-1870/remove-1000-payroll-limitation branch from f717ad0 to 6ed3edd Compare November 1, 2024 14:14
@rjlynch rjlynch merged commit 7d37d79 into master Nov 1, 2024
14 checks passed
@rjlynch rjlynch deleted the CAPT-1870/remove-1000-payroll-limitation branch November 1, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
business reviewed deploy Deploy a review app for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants