Add fraud check #3331
Merged
Add fraud check #3331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
force-pushed
the
CAPT-1185/flag-known-ninos-and-trns
branch
from
31fbf38 to
a2e1ee0
Compare
rjlynch
force-pushed
the
CAPT-1185/flag-known-ninos-and-trns
branch
from
a2e1ee0 to
fa57085
Compare
rjlynch
force-pushed
the
CAPT-1185/flag-known-ninos-and-trns
branch
from
fa57085 to
7fb712a
Compare
rjlynch
force-pushed
the
CAPT-1185/flag-known-ninos-and-trns
branch
from
7fb712a to
953d6e5
Compare
rjlynch
force-pushed
the
CAPT-1185/flag-known-ninos-and-trns
branch
3 times, most recently
from
c13d4e3 to
c006d04
Compare
rjlynch
force-pushed
the
CAPT-1185/flag-known-ninos-and-trns
branch
from
c006d04 to
8de2fda
Compare
asmega
reviewed
Oct 24, 2024
| return false unless valid? | ||
|
|
||
| ApplicationRecord.transaction do | ||
| RiskIndicator.where.not(id: records.map(&:id)).destroy_all |
There was a problem hiding this comment.
wouldn't it have been easier to delete everything then just re-add the whatevers in the CSV?
not sure if this methodology has any benefits?
There was a problem hiding this comment.
It would be a bit easier, just seemed weird to create new records when the data hasn't changed!
rjlynch
force-pushed
the
CAPT-1185/flag-known-ninos-and-trns
branch
from
8de2fda to
7bdfa3a
Compare
rjlynch
force-pushed
the
CAPT-1185/flag-known-ninos-and-trns
branch
from
7bdfa3a to
8d9c0ab
Compare
rjlynch
force-pushed
the
CAPT-1185/flag-known-ninos-and-trns
branch
2 times, most recently
from
476b4ff to
15a1c37
Compare
asmega
reviewed
Nov 1, 2024
Comment on lines
+25
to
+29
| <%= govuk_link_to( | ||
| "Download CSV", | ||
| admin_fraud_risk_csv_download_path(format: :csv), | ||
| class: "govuk-button" | ||
| ) %> |
There was a problem hiding this comment.
asmega
approved these changes
Nov 1, 2024
Adds a mechanisim for admins to upload a csv of known risky trns and ninos that will cause claims with these attributes to be flagged in the admin ui. Flagged values can be removed by uploading a CSV without those values. We've added some new functionality to the task/index notification banner. The banner now supports rendering multiple messages. If there is a single banner notification is falls back to the original view and renders a p tag, with multiple notifications it now renders a list.
When the fraud risk csv is uploaded add notes to any claims with matching details.
rjlynch
force-pushed
the
CAPT-1185/flag-known-ninos-and-trns
branch
from
15a1c37 to
5939d35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fraud check
Adds a mechanisim for admins to upload a csv of known risky trns and
ninos that will cause claims with these attributes to be flagged in the
admin ui.
Flagged values can be removed by uploading a CSV without those values.
We've added some new functionality to the task/index notification
banner. The banner now supports rendering multiple messages. If there is
a single banner notification is falls back to the original view and
renders a p tag, with multiple notifications it now renders a list.
Notes for review
The main changes in this PR is the introduction of the RiskIndicator model, the new admin controllers for managing the fraud risk CSV, and the changes to the admin/tasks/index banner notification to support rendering multiple messages.
Probably best to start by reviewing the new
app/controllers/admin/fraud_risk_csv_uploads_controller.rbas that's where the new flow kicks off.Also of note is the new claim verifier
app/models/automated_checks/claim_verifiers/fraud_risk.rb. This claim verifier doesn't create a task (not a requirement in the ticket but may be wanted in future), however a claim verifier seemed like the natural place to create a fraud risk note on the ticket.Acceptance criteria
When a known TRN submits a claim, the claim is flagged in the main body of the claim. A note needs to be created in the notes section to explain this, similar to the hold/unhold feature.
The claim cannot be approved, these feature is disabled
fraud-prevention-walkthrough.mp4