Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPT-1860 check submitted claim is a policy for current journey #3315

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

kenfodder
Copy link
Contributor

Review notes:

  • Reverting the code in app/controllers/concerns/part_of_claim_journey.rb will cause the new test added to fail with exactly the same error as Rollbar error.
  • Some minor typo tweaks

@kenfodder kenfodder requested review from rjlynch and asmega October 15, 2024 11:35
@kenfodder kenfodder marked this pull request as ready for review October 15, 2024 11:35
@kenfodder kenfodder force-pushed the CAPT-1860-submitted-claim-id-not-for-journey branch 2 times, most recently from 8968382 to 76893e2 Compare October 15, 2024 11:38
@kenfodder kenfodder force-pushed the CAPT-1860-submitted-claim-id-not-for-journey branch from 76893e2 to c9f701b Compare October 15, 2024 12:39
@kenfodder kenfodder merged commit 25e0ac2 into master Oct 15, 2024
12 checks passed
@kenfodder kenfodder deleted the CAPT-1860-submitted-claim-id-not-for-journey branch October 15, 2024 12:43
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants