CAPT 1858/handle missing info #3305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
force-pushed
the
CAPT-1858/handle-missing-info
branch
from
30e7e38 to
884190a
Compare
rjlynch
force-pushed
the
CAPT-1858/handle-missing-info
branch
from
884190a to
cf3b1ab
Compare
alkesh
approved these changes
Oct 11, 2024
There's an issue where the name fields are not being populated in the DSI oauth payload, as a temporary fix display the email address of the DFE sign in user who verified the claim
The omniauth hash from DfE sign in is not populating the first name and last name fields. We require these fields when displaying who verified a task. This commit adds a fallback to request this information from the DSI api, if it's not present in the oauth payload.
rjlynch
force-pushed
the
CAPT-1858/handle-missing-info
branch
from
cf3b1ab to
dec1fcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The omniauth hash from DfE sign in is not populating the first name and
last name fields. We require these fields when displaying who verified a
claim. This commit adds a fallback to request this information from the
DSI api, if it's not present in the oauth payload.