Fix duplciate claims in list #3298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
force-pushed
the
CAPT-1853/fix-duplicate-claims-showing
branch
from
161cdba to
8dc06dd
Compare
asmega
approved these changes
Oct 10, 2024
The awaiting provider verification scope joins to notes, claims can have more than one note, if they do duplicate claims are returned from the query. To resolve this we call distinct on the claim id. Claims have a couple of JSON columns so we can't use the `distinct` method directly, instead we have to explicitly use distinct with the claim.id. We also need to wrap the whole query in a where clause so when we chain on a `count` rails generates the correct SQL rather than something like `SELECT COUNT(count_column) FROM (SELECT DISTINCT ON (claims.id), claims.id)` Additionally we have to make sure to include `submitted_at` in the distinct clause as some of the scopes used to build the query include order by submitted_at clauses.
We move the order clause to where it's needed rather than having it on every call to `payrollable`, this lets us simplify the distinct clause as we no longer need to include the `submitted_at` in the distinct.
rjlynch
force-pushed
the
CAPT-1853/fix-duplicate-claims-showing
branch
from
94aebf2 to
256ae4d
Compare
Need to eager load the other models AFTER we dedup the clams in the query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The awaiting provider verification scope joins to notes, claims can have
more than one note, if they do duplicate claims are returned from the
query. To resolve this we call distinct on the claim id. Claims have a
couple of JSON columns so we can't use the
distinctmethod directly,instead we have to explicitly use distinct with the claim.id. We also
need to wrap the whole query in a where clause so when we chain on a
countrails generates the correct SQL rather than something likeSELECT COUNT(count_column) FROM (SELECT DISTINCT ON (claims.id), claims.id)Additionally we have to make sure to include
submitted_atin thedistinct clause as some of the scopes used to build the query include
order by submitted_at clauses.