Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAPT-1854] Provider verification status #3297

Merged
merged 3 commits into from
Oct 10, 2024
Merged

[CAPT-1854] Provider verification status #3297

merged 3 commits into from
Oct 10, 2024

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Oct 10, 2024 •
edited
Loading

Context

  • https://dfedigital.atlassian.net/browse/CAPT-1854
  • Fixes issue with provider verification status in back office
  • If claim is rejected, this takes precedence over provider verification
  • when filtering claims for provider verification it only includes claims awaiting a decision

@asmega asmega added bug Something isn't working deploy Deploy a review app for this PR labels Oct 10, 2024
@asmega asmega marked this pull request as ready for review October 10, 2024 12:53
@github-actions GitHub Actions
Copy link

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3297-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3297-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3297-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3297-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3297-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3297-web.test.teacherservices.cloud/admin

rjlynch
rjlynch approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

asmega added 3 commits October 10, 2024 13:57
@asmega
status of rejected trumps provider verification
5362b3a
@asmega
filtering awaiting_provider_verification
d594d82 
- must now also be awaiting a decision
- this prevents approved and rejected claims when filtering for this
@asmega
fix linting
3f14648
@asmega asmega force-pushed the provider-verification-status branch from 3afbd17 to 3f14648 Compare October 10, 2024 12:57
@asmega asmega merged commit b244de5 into master Oct 10, 2024
14 checks passed
@asmega asmega deleted the provider-verification-status branch October 10, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

Assignees
No one assigned
Labels
bug Something isn't working deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmega @rjlynch