Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPT-1850 show Start button only when the jounrney is open on the landing page #3294

Merged
merged 1 commit into from
Oct 11, 2024
Merged

CAPT-1850 show Start button only when the jounrney is open on the landing page #3294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/views/early_years_payment/provider/start/landing_page.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@
<%= govuk_link_to("early years financial incentive payment", "#") %>.
</p>

<%# TODO: There isn't any journey closed content, for now hide the button %>
<% if @journey_open %>
<%= govuk_start_button(text: "Start now", href: claim_path(current_journey_routing_name, "claim")) %>
<% end %>
Expand Down
3 changes: 3 additions & 0 deletions app/views/get_a_teacher_relocation_payment/landing_page.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@
"contact details for the school where you are employed"
], type: :bullet %>

<%# TODO: There isn't any journey closed content, for now hide the button %>
<% if @journey_open %>
<p class="govuk-body">
<a href="<%= claim_path(current_journey_routing_name, "claim") %>" role="button" draggable="false" class="govuk-button govuk-button--start" data-module="govuk-button">
Start
Expand All @@ -66,6 +68,7 @@
</svg>
</a>
</p>
<% end %>

<h2 class="govuk-heading-l">Deadline for applications</h2>

Expand Down
9 changes: 6 additions & 3 deletions app/views/student_loans/landing_page.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,26 +22,29 @@
</ul>

<p class="govuk-body">
It takes around 5 minutes to check if you're eligible and another 5 minutes to apply.
It takes around 5 minutes to check if you’re eligible and another 5 minutes to apply.
</p>

<p class="govuk-body">
You must apply before 31 March <%= @academic_year.end_year.to_s %>.
</p>

<%# TODO: There isn't any journey closed content, for now hide the button %>
<% if @journey_open %>
<p class="govuk-!-margin-top-8">
<a href="<%= claim_path(current_journey_routing_name, "claim") %>" role="button" draggable="false" class="govuk-button govuk-button--start" data-module="govuk-button">
Start now
<svg class="govuk-button__start-icon" xmlns="http://www.w3.org/2000/svg" width="17.5" height="19" viewBox="0 0 33 40" aria-hidden="true" focusable="false">
<path fill="currentColor" d="M0 0h13l20 20-20 20H0l20-20z"/>
</svg>
</a>
</p>
</p>
<% end %>

<h2 class="govuk-heading-m govuk-!-margin-top-4">Before you start</h2>

<p class="govuk-body">
You can use DfE Identity with this service. You'll need to provide your personal details including your National Insurance number and teacher reference number (TRN).
You can use DfE Identity with this service. You’ll need to provide your personal details including your National Insurance number and teacher reference number (TRN).
</p>
</div>
</div>
2 changes: 1 addition & 1 deletion config/locales/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ en:
award_description: "claim payment"
support_email_address: "[email protected]"
feedback_email: "[email protected]"
landing_page: "Claim back student loan repayments if you're a teacher"
landing_page: "Claim back student loan repayments if you’re a teacher"
questions:
academic_year: "Academic year you completed your Initial Teacher Training (ITT)"
claim_school_select_error: "Select the school you taught at between %{financial_year}"
Expand Down
2 changes: 1 addition & 1 deletion spec/features/backlink_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
expect(page).to have_text("Use DfE Identity to sign in")
expect(page).to have_link("Back")
click_on "Back"
expect(page).to have_text("Claim back student loan repayments if you're a teacher")
expect(page).to have_text("Claim back student loan repayments if you’re a teacher")
end

scenario "ECP/LUP journey" do
Expand Down