Rescue notify api errors #3276
Merged
Rescue notify api errors #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmega
reviewed
Oct 4, 2024
rjlynch
force-pushed
the
LUPEYALPHA-1116/notify-errors
branch
from
78c66a8 to
d2209e1
Compare
asmega
approved these changes
Oct 15, 2024
Notify uses the https://pypi.org/project/phonenumbers/ library to validate phone numbers. There's some scenarios where our regex permits a phone number that libphonenumber doesn't allow, causing notify to return an error when sending to that number. We've gone for rescuing this api error and adding a validation error to the the form. We may at some point, especially if we move message sending into a background job, want to investigate using a gem like https://github.com/daddyz/phonelib that will provide stricter phone number validations.
rjlynch
force-pushed
the
LUPEYALPHA-1116/notify-errors
branch
from
d2209e1 to
a7073ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notify uses the https://pypi.org/project/phonenumbers/ library to
validate phone numbers. There's some scenarios where our regex permits a
phone number that libphonenumber doesn't allow, causing notify to return
an error when sending to that number.
We've gone for rescuing this api error and adding a validation error to
the the form. We may at some point, especially if we move message sending
into a background job, want to investigate using a gem like
https://github.com/daddyz/phonelib that will provide stricter phone
number validations.