Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LUPEYALPHA-1121] Update find ref copy #3256

Merged
merged 2 commits into from
Oct 2, 2024
Merged

[LUPEYALPHA-1121] Update find ref copy #3256

merged 2 commits into from
Oct 2, 2024

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Oct 2, 2024

Context

@asmega asmega added the deploy Deploy a review app for this PR label Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3256-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3256-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3256-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3256-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3256-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3256-web.test.teacherservices.cloud/admin

@asmega asmega marked this pull request as ready for review October 2, 2024 11:32
rjlynch
rjlynch approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 - Even though find supposedly waits for 2 seconds that never seems to work in my experience so I think the sleep is fine 👍

@asmega
Copy link
Contributor Author

asmega commented Oct 2, 2024 •
edited
Loading

👍 - Even though find supposedly waits for 2 seconds that never seems to work in my experience so I think the sleep is fine 👍

I don't think its a find issue. i think it's on the page. i think the JS event handler isn't bound yet. so it clicks before the event handler is present so event never gets handled

@asmega asmega merged commit 64c4563 into master Oct 2, 2024
20 checks passed
@asmega asmega deleted the find-ref-copy branch October 2, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

Assignees
No one assigned
Labels
business reviewed deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmega @rjlynch