Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUPEYALPHA-1109] Validation for missing practitioner email #3247

Closed
wants to merge 2 commits into from

Conversation

vacabor
Copy link
Contributor

@vacabor vacabor commented Oct 1, 2024

Adds a validation when trying to submit a claim without supplying a practitioner email address.

image

Marking as draft because I don't like this approach:

  • I think there is an underlying bug: It seems selecting "permanent" making the claim ineligible, and then going back to change the contract type, sends the user to the "check your answers" page without asking them for the practitioner email address - I'm still looking into this
  • This error doesn't link to anywhere and we don't have a design pattern for errors within a summary list

@vacabor vacabor added the deploy Deploy a review app for this PR label Oct 1, 2024
@vacabor vacabor self-assigned this Oct 1, 2024
@vacabor
Copy link
Contributor Author

vacabor commented Oct 2, 2024

Closed in favour of #3253.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Deploy a review app for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant