Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUPEYALPHA-1045] EY practitioner find reference screen #3237

Merged
merged 6 commits into from
Sep 30, 2024

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Sep 26, 2024

Context

Changes

  • In order to support email in url query params and the way the current controller/journey concerns does a lot redirect, I've had to make tweaks to ensure these get passed around so they are not lost. This will affect all journeys
  • I have concern where query params are stripped, thinking of mostly Safari where it can strip certain query params, may cause this feature to not work as we use it to pass state
  • Updated email sent to practitioner to inject correct url to continue their journey

@asmega asmega force-pushed the ey-prac-find-ref branch 2 times, most recently from 2cc2319 to 9c5c2b2 Compare September 26, 2024 16:51
@asmega asmega added the deploy Deploy a review app for this PR label Sep 26, 2024
], type: :bullet %>

<p>
Contact us at <%= govuk_link_to "[email protected]", "mailto:[email protected]" %> for assistance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Contact us at <%= govuk_link_to "[email protected]", "mailto:[email protected]" %> for assistance.
Contact us at <%= govuk_mail_to "[email protected]" %> for assistance.

also, is it worth putting this email in config/locales? we have the emails for the provider journey in there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep agreed, i've stuck this on the last commit

@asmega asmega merged commit 3863e14 into master Sep 30, 2024
14 checks passed
@asmega asmega deleted the ey-prac-find-ref branch September 30, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
business reviewed deploy Deploy a review app for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants