Add task if provider / claimant details match #3236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
force-pushed
the
LUPEYALPHA-637
branch
2 times, most recently
from
a799267 to
7eeff75
Compare
kenfodder
reviewed
Nov 4, 2024
| def provider_and_claimant_names_match? | ||
| return false unless verified? | ||
|
|
||
| provider_first_name&.downcase == claim.first_name.downcase && |
There was a problem hiding this comment.
I haven't checked, just wondering if this doesn't get tripped by leading or trailing spaces?
There was a problem hiding this comment.
These names are set in app/forms/journeys/early_years_payment/provider/authenticated/claimant_name_form.rb which uses the NameFormatValidator so should be safe
| def provider_and_claimant_emails_match? | ||
| return false unless verified? | ||
|
|
||
| provider_email&.downcase == claim.email_address.downcase |
slorek
approved these changes
Nov 8, 2024
rjlynch
force-pushed
the
LUPEYALPHA-637
branch
from
7eeff75 to
2de95a4
Compare
If the claimant and provider have matching details (name or email) we want to raise an admin task for ops to check that the claimant isn't trying to approve their own claim.
rjlynch
force-pushed
the
LUPEYALPHA-637
branch
from
2de95a4 to
9d843c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the claimant and provider have matching details (name or email) we
want to raise an admin task for ops to check that the claimant isn't
trying to approve their own claim.