Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LUPEYALPHA-984] EY practitioner enter home address #3235

Merged
merged 1 commit into from
Sep 27, 2024
Merged

[LUPEYALPHA-984] EY practitioner enter home address #3235

merged 1 commit into from
Sep 27, 2024

Conversation

alkesh
Copy link
Contributor

@alkesh alkesh commented Sep 26, 2024

basing off LUPEYALPHA-983-EY-practitioner-personal-details branch

@alkesh alkesh added deploy Deploy a review app for this PR and removed deploy Deploy a review app for this PR labels Sep 26, 2024
@github-actions GitHub Actions
Copy link

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3235-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3235-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3235-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3235-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3235-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3235-web.test.teacherservices.cloud/admin

@alkesh alkesh added the deploy Deploy a review app for this PR label Sep 26, 2024
rjlynch
rjlynch approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only question is how come we can't just render the address form for this journey? Is it because we don't want to include the "questions.personal_details" caption?

@alkesh
Copy link
Contributor Author

alkesh commented Sep 26, 2024

LGTM, only question is how come we can't just render the address form for this journey? Is it because we don't want to include the "questions.personal_details" caption?

yeah - there are 2 changes required for this journey - no caption, and also the title is size 'l' instead of 'xl'.

@alkesh alkesh force-pushed the LUPEYALPHA-983-EY-practitioner-personal-details branch from d0f300e to 77c8d27 Compare September 26, 2024 15:18
Base automatically changed from LUPEYALPHA-983-EY-practitioner-personal-details to master September 26, 2024 16:03
@alkesh alkesh force-pushed the LUPEYALPHA-984-EY-practitioner-home-address branch from f7367db to 7bbe264 Compare September 26, 2024 16:05
@alkesh alkesh force-pushed the LUPEYALPHA-984-EY-practitioner-home-address branch from 7bbe264 to 8ad7eed Compare September 27, 2024 11:43
@alkesh alkesh merged commit 1d87be8 into master Sep 27, 2024
14 checks passed
@alkesh alkesh deleted the LUPEYALPHA-984-EY-practitioner-home-address branch September 27, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

Assignees
No one assigned
Labels
deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alkesh @rjlynch