Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LUPEYALPHA-983] EY practitioner personal details #3234

Merged
merged 3 commits into from
Sep 26, 2024
Merged

[LUPEYALPHA-983] EY practitioner personal details #3234

merged 3 commits into from
Sep 26, 2024

Conversation

alkesh
Copy link
Contributor

@alkesh alkesh commented Sep 26, 2024 •
edited
Loading

No description provided.

@alkesh alkesh added the deploy Deploy a review app for this PR label Sep 26, 2024
@github-actions GitHub Actions
Copy link

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3234-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3234-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3234-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3234-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3234-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3234-web.test.teacherservices.cloud/admin

@alkesh alkesh force-pushed the LUPEYALPHA-983-EY-practitioner-personal-details branch from 5753abe to d0f300e Compare September 26, 2024 11:43
rjlynch
rjlynch approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alkesh alkesh force-pushed the LUPEYALPHA-982-EY-practitioner-how-we-use-your-information branch from 552f493 to d02575a Compare September 26, 2024 15:10
Base automatically changed from LUPEYALPHA-982-EY-practitioner-how-we-use-your-information to master September 26, 2024 15:18
@alkesh alkesh force-pushed the LUPEYALPHA-983-EY-practitioner-personal-details branch from d0f300e to 77c8d27 Compare September 26, 2024 15:18
@alkesh
Copy link
Contributor Author

alkesh commented Sep 26, 2024

hmm - just noticed - the headings are one size too big compared to the prototype.
The main heading should large instead of xlarge, and the sub-headings should be medium.

rjlynch
rjlynch approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alkesh alkesh merged commit 2dc4877 into master Sep 26, 2024
14 checks passed
@alkesh alkesh deleted the LUPEYALPHA-983-EY-practitioner-personal-details branch September 26, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

Assignees
No one assigned
Labels
deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alkesh @rjlynch