Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes admin matching claims ui #3232

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

rjlynch
Copy link
Contributor

@rjlynch rjlynch commented Sep 25, 2024

Updates the logic used when showing which attributes on the claim
triggered a match to take into account the matching groups, eg if two
claims have a matching sort code but different account number we don't
want to show the sort code as the reason for the match in the ui.

@rjlynch rjlynch force-pushed the LUPEYALPHA-1108/fix-matching-claims-ui branch from 99fa989 to c59f814 Compare September 25, 2024 13:49
@rjlynch rjlynch marked this pull request as ready for review September 25, 2024 14:01
@rjlynch rjlynch added the deploy Deploy a review app for this PR label Sep 25, 2024
@rjlynch rjlynch force-pushed the LUPEYALPHA-1108/fix-matching-claims-ui branch from c59f814 to 2cbd2d2 Compare September 25, 2024 14:26
@rjlynch rjlynch changed the title Fixes admin matching claims ui WIP. - Fixes admin matching claims ui Sep 25, 2024
@rjlynch rjlynch force-pushed the LUPEYALPHA-1108/fix-matching-claims-ui branch from 2cbd2d2 to 3ee7a1f Compare September 25, 2024 14:27
@rjlynch rjlynch force-pushed the LUPEYALPHA-1108/fix-matching-claims-ui branch from 3ee7a1f to 8d8d0b2 Compare September 26, 2024 13:56
@rjlynch rjlynch changed the title WIP. - Fixes admin matching claims ui Fixes admin matching claims ui Sep 26, 2024
Updates the logic used when showing which attributes on the claim
triggered a match to take into account the matching groups, eg if two
claims have a matching sort code but different account number we don't
want to show the sort code as the reason for the match in the ui.
@rjlynch rjlynch force-pushed the LUPEYALPHA-1108/fix-matching-claims-ui branch from 8d8d0b2 to 35c9a10 Compare September 27, 2024 09:48
@rjlynch rjlynch merged commit 2a09444 into master Sep 27, 2024
14 checks passed
@rjlynch rjlynch deleted the LUPEYALPHA-1108/fix-matching-claims-ui branch September 27, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Deploy a review app for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants