Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUPEYALPHA 1096/fix claim started date 3 #3224

Merged
merged 1 commit into from
Sep 25, 2024
Merged

LUPEYALPHA 1096/fix claim started date 3 #3224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/helpers/admin/claims_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def admin_student_loan_details(claim)

def admin_submission_details(claim)
[
[translate("admin.started_at"), l(claim.created_at)],
[translate("admin.started_at"), l(claim.started_at)],
[translate("admin.submitted_at"), l(claim.submitted_at)],
[translate("admin.decision_deadline"), l(claim.decision_deadline_date)],
[translate("admin.decision_overdue"), decision_deadline_warning(claim)]
Expand Down
5 changes: 5 additions & 0 deletions db/migrate/20240924113642_make_claims_started_at_not_null.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
class MakeClaimsStartedAtNotNull < ActiveRecord::Migration[7.0]
def change
change_column_null :claims, :started_at, false
end
end
4 changes: 2 additions & 2 deletions db/schema.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#
# It's strongly recommended that you check this file into your version control system.

ActiveRecord::Schema[7.0].define(version: 2024_09_24_095435) do
ActiveRecord::Schema[7.0].define(version: 2024_09_24_113642) do
# These are extensions that must be enabled in order to support this database
enable_extension "citext"
enable_extension "pg_trgm"
Expand Down Expand Up @@ -111,7 +111,7 @@
t.text "onelogin_idv_first_name"
t.text "onelogin_idv_last_name"
t.date "onelogin_idv_date_of_birth"
t.datetime "started_at", precision: nil
t.datetime "started_at", precision: nil, null: false
t.index ["academic_year"], name: "index_claims_on_academic_year"
t.index ["created_at"], name: "index_claims_on_created_at"
t.index ["eligibility_type", "eligibility_id"], name: "index_claims_on_eligibility_type_and_eligibility_id"
Expand Down
2 changes: 1 addition & 1 deletion spec/features/admin/admin_view_full_claim_further_education_payments_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
address_line_4: "Oregon",
postcode: "AB12 3CD",
email_address: "[email protected]",
created_at: DateTime.new(2024, 8, 1, 9, 0, 0),
started_at: DateTime.new(2024, 8, 1, 9, 0, 0),
submitted_at: DateTime.new(2024, 8, 1, 11, 0, 0),
academic_year: AcademicYear.new(2024)
)
Expand Down