LUPEYALPHA 1096/fix claim started date 2 #3222
Conversation
rjlynch
force-pushed
the
LUPEYALPHA-1096/fix-claim-started-date-2
branch
3 times, most recently
from
c8cbcb0 to
6a44b2f
Compare
rjlynch
changed the base branch from
master
to
LUPEYALPHA-1096/fix-claim-started-date-1
| AND claims.started_at IS NULL | ||
| SQL | ||
|
|
||
| change_column_null :claims, :started_at, false |
There was a problem hiding this comment.
feels risky without a prior run? might save you more time if we do this change after confirmation? or happy to keep in if you're feeling confident, i don't think there's any material risk
There was a problem hiding this comment.
We're setting this on new claims in the previous PR and we're using the created_at timestamp which should be present on all records as rails is setting it. But yeah I think for avoiding risk we'll split this out into a separate pr (and also because I forgot to remove the not null constraint in the down migration 🙈)
There was a problem hiding this comment.
Have moved the migration to make the column non nullable to this pr https://github.com/DFE-Digital/claim-additional-payments-for-teaching/pull/3224/files
rjlynch
force-pushed
the
LUPEYALPHA-1096/fix-claim-started-date-2
branch
2 times, most recently
from
9526105 to
e281157
Compare
rjlynch
force-pushed
the
LUPEYALPHA-1096/fix-claim-started-date-1
branch
from
08eef0f to
c656ee5
Compare
If the claim has a journey session we try and set the `started_at` to that, if it doesn't have a journey session we'll just use the `created_at` timestamp, which for claims pre the introduction of journey sessions will be the started at time.
rjlynch
force-pushed
the
LUPEYALPHA-1096/fix-claim-started-date-2
branch
from
e281157 to
bb99389
Compare
Back fill started at
If the claim has a journey session we try and set the
started_attothat, if it doesn't have a journey session we'll just use the
created_attimestamp, which for claims pre the introduction of journeysessions will be the started at time.
PR 2 of 3
1 #3221
3 #3224