Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match across all policies #3206

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

rjlynch
Copy link
Contributor

@rjlynch rjlynch commented Sep 19, 2024

Requirement is to check for matching claims across all policies, except
for IRP, which should only flag matches with other IRP policies.

At the minute the only attribute we use on eligibility when checking for
matches is TRN, which is present in all the eligibilities we compare, if
however we start checking other attributes the db will throw an error as
the column may not be present on all eligibilities, hence having to
update the "matching_claims - blank trn" test.

@rjlynch rjlynch added the deploy Deploy a review app for this PR label Sep 19, 2024
@rjlynch rjlynch force-pushed the LUPEYALPHA-1043/update-claim-matching branch 2 times, most recently from 766f5d7 to ed03ca1 Compare September 20, 2024 09:54
@rjlynch rjlynch marked this pull request as ready for review September 30, 2024 08:57
Requirement is to check for matching claims across all policies, except
for IRP, which should only flag matches with other IRP policies.

At the minute the only attribute we use on eligibility when checking for
matches is TRN, which is present in all the eligibilities we compare, if
however we start checking other attributes the db will throw an error as
the column may not be present on all eligibilities, hence having to
update the "matching_claims - blank trn" test.
`OTHER_CLAIMABLE_POLICIES` is only used for matching policies, as of
`b6c6b4275c` this constant is not used when detecting claims that
prevent payments.
@rjlynch rjlynch force-pushed the LUPEYALPHA-1043/update-claim-matching branch from ed03ca1 to 1d48645 Compare September 30, 2024 09:26
@rjlynch rjlynch merged commit 580daf0 into master Sep 30, 2024
14 checks passed
@rjlynch rjlynch deleted the LUPEYALPHA-1043/update-claim-matching branch September 30, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Deploy a review app for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants