Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE provider chaser email #3199

Merged
merged 7 commits into from
Sep 24, 2024
Merged

FE provider chaser email #3199

merged 7 commits into from
Sep 24, 2024

Conversation

kenfodder
Copy link
Contributor

@kenfodder kenfodder commented Sep 17, 2024

  • Add a timestamp to when the last provider email was sent
  • Checks for claims with a provider email last sent over 3 weeks ago and sends a chase email
  • It updates that timestamp so it will send again in 3 weeks
  • Daily job running at 8am

UPDATE

  • It's updated to the send the chase email ONLY ONCE - clarified with Product
  • Already verified, held and rejected claims are excluded from being send a chaser email.

@kenfodder kenfodder added the deploy Deploy a review app for this PR label Sep 17, 2024
@kenfodder kenfodder marked this pull request as ready for review September 18, 2024 12:27
@kenfodder kenfodder requested a review from rjlynch September 18, 2024 12:28
@kenfodder kenfodder changed the title Fe provider chaser email FE provider chaser email Sep 18, 2024
slorek
slorek previously requested changes Sep 20, 2024
Copy link
Contributor

@slorek slorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need some mechanism to cap the number of emails sent. I think the implementation here will send emails every 3 weeks forever, even if the claim is rejected. We should probably at least not include rejected claims, and consider a cap to the number of emails which are sent in total.

@kenfodder
Copy link
Contributor Author

kenfodder commented Sep 23, 2024

I think we need some mechanism to cap the number of emails sent. I think the implementation here will send emails every 3 weeks forever, even if the claim is rejected. We should probably at least not include rejected claims, and consider a cap to the number of emails which are sent in total.

  • It's updated to the send the chase email ONLY ONCE - clarified with Product
  • Already verified, held and rejected claims are excluded from being send a chaser email.

92c09c3

@kenfodder kenfodder force-pushed the fe-provider-chaser-email branch from 92c09c3 to d7b01a0 Compare September 24, 2024 12:02
@kenfodder kenfodder requested a review from slorek September 24, 2024 12:38
@kenfodder kenfodder dismissed slorek’s stale review September 24, 2024 13:02

Changes done, Steve away on leave

@kenfodder kenfodder merged commit 73e8a8a into master Sep 24, 2024
14 checks passed
@kenfodder kenfodder deleted the fe-provider-chaser-email branch September 24, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Deploy a review app for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants