Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record who sent the email to the provider #3167

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

rjlynch
Copy link
Contributor

@rjlynch rjlynch commented Sep 9, 2024

The figma designs require us to display the admin who resent the provider verification email. To capture this information we use the existing note mechanism on claims. This is a bit fragile as we assume the only "provider_verification" note is for emails being sent. It seems like the label on notes maps to a task name, so we went with that for the label. If in future we can take other provider verification notes we may want to consider renaming this email specific label.

Screenshot 2024-09-09 at 16 39 03
Screenshot 2024-09-09 at 16 41 38

@rjlynch rjlynch added the deploy Deploy a review app for this PR label Sep 10, 2024
@rjlynch rjlynch marked this pull request as ready for review September 10, 2024 10:38
@rjlynch rjlynch force-pushed the LUPEYALPHA-356/provider-verification-email branch from 198eabe to 890866d Compare September 11, 2024 09:26
@rjlynch rjlynch force-pushed the LUPEYALPHA-356/provider-verification-email branch from 890866d to c8ba0b5 Compare September 11, 2024 10:17
Copy link
Contributor

@slorek slorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the email is resent multiple times it looks like we will only display the latest instance, is that correct?

@rjlynch rjlynch force-pushed the LUPEYALPHA-356/provider-verification-email branch from c8ba0b5 to 70ec428 Compare September 12, 2024 12:34
@rjlynch
Copy link
Contributor Author

rjlynch commented Sep 12, 2024

If the email is resent multiple times it looks like we will only display the latest instance, is that correct?

Next to the button we'll only show the latest instance but we record each time it's sent in the case notes

Screenshot 2024-09-12 at 13 52 15

@slorek
Copy link
Contributor

slorek commented Sep 12, 2024

If the email is resent multiple times it looks like we will only display the latest instance, is that correct?

Next to the button we'll only show the latest instance but we record each time it's sent in the case notes

Rather than showing only the latest one, I don't see any reason why we can't just show all the relevant notes. I think this would be more helpful in the event of a support request.

@rjlynch
Copy link
Contributor Author

rjlynch commented Sep 12, 2024

If the email is resent multiple times it looks like we will only display the latest instance, is that correct?

Next to the button we'll only show the latest instance but we record each time it's sent in the case notes

Rather than showing only the latest one, I don't see any reason why we can't just show all the relevant notes. I think this would be more helpful in the event of a support request.

Have updated this to now show all the email sending events 734c022. I've also tacked on a bug fix to this pr to fix the copy when the email has been sent to the provider c3c004c

Screenshot 2024-09-12 at 17 03 08

The figma designs require us to display the admin who resent the
provider verification email. To capture this information we use the
existing note mechanism on claims. This is a bit fragile as we assume
the only "provider_verification" note is for emails being sent. It seems
like the label on notes maps to a task name, so we went with that for
the label. If in future we can take other provider verification notes we
may want to consider renaming this email specific label.
Button copy has been changed
There's a couple of states this partial can be in

* Verification email not sent to the provider
  - When the claim was flagged as a duplicate so we didn't send the
    email on claimant journey completion AND and admin is yet to
    manually send the verification email by clicking the button

* Initial verification email sent to the provider
  - The claim was not flagged as a duplicate so the initial email was
    sent when the claimant journey was completed

* Email sent by the admin
  - The claim was flagged as a duplicate but an admin has now clicked
    the send email button

To make the view a bit less confussing we've pulled out a partial for
the provider verification completed and uncompleted states.
Feedback on PR we want to show all admin email sending events on the
task, not just the latest one
@rjlynch rjlynch force-pushed the LUPEYALPHA-356/provider-verification-email branch from 734c022 to 691e245 Compare September 16, 2024 09:22
@rjlynch rjlynch merged commit 8d307fc into master Sep 16, 2024
14 checks passed
@rjlynch rjlynch deleted the LUPEYALPHA-356/provider-verification-email branch September 16, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Deploy a review app for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants