-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record who sent the email to the provider #3167
Conversation
198eabe
to
890866d
Compare
890866d
to
c8ba0b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the email is resent multiple times it looks like we will only display the latest instance, is that correct?
c8ba0b5
to
70ec428
Compare
Rather than showing only the latest one, I don't see any reason why we can't just show all the relevant notes. I think this would be more helpful in the event of a support request. |
Have updated this to now show all the email sending events 734c022. I've also tacked on a bug fix to this pr to fix the copy when the email has been sent to the provider c3c004c |
The figma designs require us to display the admin who resent the provider verification email. To capture this information we use the existing note mechanism on claims. This is a bit fragile as we assume the only "provider_verification" note is for emails being sent. It seems like the label on notes maps to a task name, so we went with that for the label. If in future we can take other provider verification notes we may want to consider renaming this email specific label.
Button copy has been changed
There's a couple of states this partial can be in * Verification email not sent to the provider - When the claim was flagged as a duplicate so we didn't send the email on claimant journey completion AND and admin is yet to manually send the verification email by clicking the button * Initial verification email sent to the provider - The claim was not flagged as a duplicate so the initial email was sent when the claimant journey was completed * Email sent by the admin - The claim was flagged as a duplicate but an admin has now clicked the send email button To make the view a bit less confussing we've pulled out a partial for the provider verification completed and uncompleted states.
Feedback on PR we want to show all admin email sending events on the task, not just the latest one
734c022
to
691e245
Compare
The figma designs require us to display the admin who resent the provider verification email. To capture this information we use the existing note mechanism on claims. This is a bit fragile as we assume the only "provider_verification" note is for emails being sent. It seems like the label on notes maps to a task name, so we went with that for the label. If in future we can take other provider verification notes we may want to consider renaming this email specific label.