Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LUPEYALPHA-955 - Add identity confirmation task to FE that auto passes #3164

Merged
merged 3 commits into from
Sep 9, 2024
Merged

LUPEYALPHA-955 - Add identity confirmation task to FE that auto passes #3164

merged 3 commits into from
Sep 9, 2024

Conversation

kenfodder
Copy link
Contributor

@kenfodder kenfodder commented Sep 6, 2024 •
edited
Loading

  • Show task outcome with OneLogin timestamp
  • Tidy up status tags with tasks

Screenshot 2024-09-06 at 14 52 39

Screenshot 2024-09-06 at 14 52 45

Screenshot 2024-09-06 at 14 52 33

@kenfodder kenfodder force-pushed the fe-identity-confirmation-task branch from 44d6395 to da13c20 Compare September 6, 2024 15:14
@kenfodder kenfodder marked this pull request as ready for review September 6, 2024 15:18
@kenfodder kenfodder added the deploy Deploy a review app for this PR label Sep 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3164-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3164-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3164-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3164-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3164-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3164-web.test.teacherservices.cloud/admin

rjlynch
rjlynch approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think in future we'll want to change the auto pass method to something like

def auto_pass
  create_task(match: nil, passed: true) if claim.identity_confirmed_with_onelogin?
end

but I think checking the policy is fine for now

slorek
slorek requested changes Sep 6, 2024
View reviewed changes
app/models/automated_checks/claim_verifiers/identity.rb Outdated Show resolved Hide resolved
app/views/admin/tasks/_task_outcome.html.erb Outdated Show resolved Hide resolved
@kenfodder kenfodder requested a review from slorek September 6, 2024 17:09
@kenfodder
Copy link
Contributor Author

@slorek @rjlynch Added improvement on another commit: a9b3884

@kenfodder kenfodder force-pushed the fe-identity-confirmation-task branch from 6914b0f to 8d928f0 Compare September 9, 2024 09:19
@kenfodder kenfodder merged commit 5f21360 into master Sep 9, 2024
14 checks passed
@kenfodder kenfodder deleted the fe-identity-confirmation-task branch September 9, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

@slorek slorek slorek approved these changes

@asmega asmega Awaiting requested review from asmega

@alkesh alkesh Awaiting requested review from alkesh

Assignees
No one assigned
Labels
deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenfodder @slorek @rjlynch