Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show type of contract claimant selected #3163

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Show type of contract claimant selected #3163

merged 4 commits into from
Sep 6, 2024

Conversation

rjlynch
Copy link
Contributor

@rjlynch rjlynch commented Sep 6, 2024

Previously we were always showing permanent, we need to show the option
the claimant selected.

@rjlynch rjlynch added the deploy Deploy a review app for this PR label Sep 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3163-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3163-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3163-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3163-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3163-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3163-web.test.teacherservices.cloud/admin

@rjlynch rjlynch force-pushed the update-provider-confrimation-form-copy branch from 03a9cd2 to 020b384 Compare September 6, 2024 14:37
@rjlynch rjlynch removed the deploy Deploy a review app for this PR label Sep 6, 2024
@rjlynch rjlynch added the deploy Deploy a review app for this PR label Sep 6, 2024
@rjlynch rjlynch force-pushed the update-provider-confrimation-form-copy branch from d270df2 to 1fa6820 Compare September 6, 2024 15:59
@rjlynch rjlynch force-pushed the update-provider-confrimation-form-copy branch from 1fa6820 to 3e64b3e Compare September 6, 2024 16:01
@rjlynch
Show type of contract claimant selected
f06fd0a 
Previously we were always showing permanent, we need to show the option
the claimant selected.
@rjlynch
Update the support email address
eb1b0b6
@rjlynch
Branch on fixed_term_full_year
79effaa 
If the claimant has a fixed term contract we need to check the
fixed_term_full_year flag to determine whether or not to show the
variable hours provider questions
@rjlynch
Quick copy fix
5a2a5e0 
Need to show the duration of the contract for long term fixed
@rjlynch rjlynch force-pushed the update-provider-confrimation-form-copy branch from d22232c to 5a2a5e0 Compare September 6, 2024 16:08
@rjlynch rjlynch merged commit b1571e5 into master Sep 6, 2024
14 checks passed
@rjlynch rjlynch deleted the update-provider-confrimation-form-copy branch September 6, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenfodder kenfodder kenfodder approved these changes

Assignees
No one assigned
Labels
deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjlynch @kenfodder